From patchwork Thu Nov 15 14:42:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: iscsi: fix segfault in url parsing Date: Thu, 15 Nov 2012 04:42:06 -0000 From: Peter Lieven X-Patchwork-Id: 199314 Message-Id: <50A4FF3E.4010209@dlhnet.de> To: "qemu-devel@nongnu.org" Cc: kwolf@redhat.com, ronnie sahlberg If an invalid URL is specified iscsi_get_error(iscsi) is called with iscsi == NULL. Signed-off-by: Peter Lieven Acked-By: ronniesahlberg@gmail.com --- block/iscsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) } diff --git a/block/iscsi.c b/block/iscsi.c index d0b1a10..b5c3161 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -947,8 +947,7 @@ static int iscsi_open(BlockDriverState *bs, const char *filename, int flags) iscsi_url = iscsi_parse_full_url(iscsi, filename); if (iscsi_url == NULL) { - error_report("Failed to parse URL : %s %s", filename, - iscsi_get_error(iscsi)); + error_report("Failed to parse URL : %s", filename); ret = -EINVAL; goto out;