Patchwork Disable libsanitizer if C++ is not being built

login
register
mail settings
Submitter Siddhesh Poyarekar
Date Nov. 15, 2012, 2:22 p.m.
Message ID <20121115195221.2d98bb1e@spoyarek>
Download mbox | patch
Permalink /patch/199298/
State New
Headers show

Comments

Siddhesh Poyarekar - Nov. 15, 2012, 2:22 p.m.
Hi,

Current HEAD fails build when --enable-languages=c, i.e. C++ is not
being built.  Attached patch fixes this.

Regards,
Siddhesh

ChangeLog:

2012-11-15  Siddhesh Poyarekar  <siddhesh@redhat.com>

	* configure.ac: Disable libsanitizer if we're not building C++.
	* configure: Regenerate.
Steven Bosscher - Nov. 15, 2012, 2:48 p.m.
> Current HEAD fails build when --enable-languages=c, i.e. C++ is not
> being built.  Attached patch fixes this.

Eh???

Isn't C++ always built, because gcc itself requires it?

Ciao!
Steven
Michael Matz - Nov. 15, 2012, 2:59 p.m.
Hi,

On Thu, 15 Nov 2012, Steven Bosscher wrote:

> > Current HEAD fails build when --enable-languages=c, i.e. C++ is not
> > being built.  Attached patch fixes this.
> 
> Eh???

Uhh???

> Isn't C++ always built, because gcc itself requires it?

Without bootstrapping it doesn't, no.


Ciao,
Michael.
Siddhesh Poyarekar - Nov. 21, 2012, 7:13 a.m.
Hi,

Ping!

Siddhesh

On Thu, 15 Nov 2012 19:52:21 +0530, Siddhesh wrote:

> Hi,
> 
> Current HEAD fails build when --enable-languages=c, i.e. C++ is not
> being built.  Attached patch fixes this.
> 
> Regards,
> Siddhesh
> 
> ChangeLog:
> 
> 2012-11-15  Siddhesh Poyarekar  <siddhesh@redhat.com>
> 
> 	* configure.ac: Disable libsanitizer if we're not building
> C++.
> 	* configure: Regenerate.
>
Siddhesh Poyarekar - Nov. 27, 2012, 10:03 a.m.
Ping!

Siddhesh

On Wed, Nov 21, 2012 at 12:43:10PM +0530, Siddhesh Poyarekar wrote:
> Hi,
> 
> Ping!
> 
> Siddhesh
> 
> On Thu, 15 Nov 2012 19:52:21 +0530, Siddhesh wrote:
> 
> > Hi,
> > 
> > Current HEAD fails build when --enable-languages=c, i.e. C++ is not
> > being built.  Attached patch fixes this.
> > 
> > Regards,
> > Siddhesh
> > 
> > ChangeLog:
> > 
> > 2012-11-15  Siddhesh Poyarekar  <siddhesh@redhat.com>
> > 
> > 	* configure.ac: Disable libsanitizer if we're not building
> > C++.
> > 	* configure: Regenerate.
> > 
>
Jakub Jelinek - Nov. 27, 2012, 10:05 a.m.
On Thu, Nov 15, 2012 at 07:52:21PM +0530, Siddhesh Poyarekar wrote:
> 2012-11-15  Siddhesh Poyarekar  <siddhesh@redhat.com>
> 
> 	* configure.ac: Disable libsanitizer if we're not building C++.
> 	* configure: Regenerate.

Ok, thanks.

	Jakub
Siddhesh Poyarekar - Nov. 27, 2012, 10:31 a.m.
On Tue, Nov 27, 2012 at 11:05:47AM +0100, Jakub Jelinek wrote:
> On Thu, Nov 15, 2012 at 07:52:21PM +0530, Siddhesh Poyarekar wrote:
> > 2012-11-15  Siddhesh Poyarekar  <siddhesh@redhat.com>
> > 
> > 	* configure.ac: Disable libsanitizer if we're not building C++.
> > 	* configure: Regenerate.
> 
> Ok, thanks.
> 

Could you please commit it for me?  I don't have write access.

Thanks,
Siddhesh

Patch

diff --git a/configure b/configure
index d72d4f9..16bbaa8 100755
--- a/configure
+++ b/configure
@@ -6437,11 +6437,11 @@  case ,${enable_languages},:${enable_objc_gc} in
     ;;
 esac
 
-# Disable libitm if we're not building C++
+# Disable libitm and libsanitizer if we're not building C++
 case ,${enable_languages}, in
   *,c++,*) ;;
   *)
-    noconfigdirs="$noconfigdirs target-libitm"
+    noconfigdirs="$noconfigdirs target-libitm target-libsanitizer"
     ;;
 esac
 
diff --git a/configure.ac b/configure.ac
index 24ea7e5..cd6721e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2008,11 +2008,11 @@  case ,${enable_languages},:${enable_objc_gc} in
     ;;
 esac
 
-# Disable libitm if we're not building C++
+# Disable libitm and libsanitizer if we're not building C++
 case ,${enable_languages}, in
   *,c++,*) ;;
   *)
-    noconfigdirs="$noconfigdirs target-libitm"
+    noconfigdirs="$noconfigdirs target-libitm target-libsanitizer"
     ;;
 esac