Patchwork Copy libsanitizer from llvm at revision 167890

login
register
mail settings
Submitter Dodji Seketeli
Date Nov. 15, 2012, 12:38 p.m.
Message ID <87pq3fvy5d.fsf@redhat.com>
Download mbox | patch
Permalink /patch/199268/
State New
Headers show

Comments

Dodji Seketeli - Nov. 15, 2012, 12:38 p.m.
Diego Novillo <dnovillo@google.com> writes:

> (Adding ASAN maintainers to the CC)
>
> On Wed, Nov 14, 2012 at 7:55 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Wed, Nov 14, 2012 at 4:44 AM, Rainer Orth
>>>
>>> Btw., currently there's no libsanitizer maintainer listed in
>>> MAINTAINERS.  This needs to change.
>>>
>>
>> That is the real problem.   We need a GCC libsanitizer maintainer
>
> We already have FOUR.  Kostya, Jakub, Dmitry and Dodji.
>
> Folks, please update MAINTAINERS to avoid confusion.

Done, and committed the below.

    ChangeLog:
    
    	* MAINTAINERS: (asan.c, related): Add myself.



Thanks.
Rainer Orth - Nov. 15, 2012, 2:33 p.m.
Dmitry Vyukov <dvyukov@google.com> writes:

> Does it look good to you (not yet committed)?
> (Dodji, I've replaced spaces with tabs in your record)
[...]
> Index: MAINTAINERS
> ===================================================================
> --- MAINTAINERS (revision 193530)
> +++ MAINTAINERS (working copy)
> @@ -294,7 +294,9 @@
>  register allocation Kenneth Zadeck zadeck@naturalbridge.com
>  register allocation Seongbae Park seongbae.park@gmail.com
>  selective scheduling Andrey Belevantsev abel@ispras.ru
> -asan.c, related         Dodji Seketeli dodji@redhat.com
> +asan.c, related Dodji Seketeli dodji@redhat.com
> +libsanitizer, asan.c Dmitry Vyukov dvyukov@google.com
> +libsanitizer, asan.c Kostya Serebryany kcc@google.com

The lists are usually kept sorted alphabetically, first by area, then
alphabetically by maintainer's/reviewer's last name, though there are
inconsistencies here already.

	Rainer
Richard Earnshaw - Nov. 15, 2012, 2:37 p.m.
On 15/11/12 12:38, Dodji Seketeli wrote:
> diff --git a/MAINTAINERS b/MAINTAINERS
> index adec7a4..825c602 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -294,6 +294,7 @@ register allocation	Peter Bergner		bergner@vnet.ibm.com
>   register allocation	Kenneth Zadeck		zadeck@naturalbridge.com
>   register allocation	Seongbae Park		seongbae.park@gmail.com
>   selective scheduling	Andrey Belevantsev	abel@ispras.ru
> +asan.c, related         Dodji Seketeli		dodji@redhat.com
>
>   Note that while reviewers can approve changes to parts of the compiler
>   that they maintain, they still need approval for their own patches
>
>
> Thanks.
>

That section seems to be largely ordered alphabetically.  'Twould be 
better if asan (or should it be ASAN, or ASan)[1] came at the 
appropriate point.

R.

[1]  Am I the only one who finds the name somewhat cryptic?
Rainer Orth - Nov. 15, 2012, 2:42 p.m.
Dmitry Vyukov <dvyukov@google.com> writes:

> To what section do I need to add myself? There are "Reviewers" and
> "Various Maintainers".

"Reviewers" since that's what the Steering Committee's message mentioned.

	Rainer
Diego Novillo - Nov. 15, 2012, 2:47 p.m.
On 2012-11-15 09:43 , Dmitry Vyukov wrote:

> Does it look better? (still in Reviewers section)

Looks fine.  Thanks.

Incidentally, Dodji, now that I look at your entry.  I think making 
yours state "libsanitizer, asan.c" would be better.


Diego.
Jakub Jelinek - Nov. 15, 2012, 2:56 p.m.
On Thu, Nov 15, 2012 at 06:54:43PM +0400, Dmitry Vyukov wrote:
> Yes, I think people will search by "libsanitizer" (or "asan").
> 
> Do I need to add Jakub Jelinek as reviewer as well?

I can add myself after you commit it, or you can add me.

	Jakub
Diego Novillo - Nov. 15, 2012, 3:04 p.m.
On Thu, Nov 15, 2012 at 9:37 AM, Richard Earnshaw <rearnsha@arm.com> wrote:

> [1]  Am I the only one who finds the name somewhat cryptic?

It's just a name :)  No more cryptic than "mudflap".  Took me a while
to get used to that one!

Kostya et al have a family of sanitizers now and they are all
abbreviated similarly: asan, tsan, msan (memory)... they'll run out of
letters soon if they keep going at this pace.


Diego.
Jakub Jelinek - Nov. 15, 2012, 3:12 p.m.
On Thu, Nov 15, 2012 at 07:07:46PM +0400, Dmitry Vyukov wrote:
> On Thu, Nov 15, 2012 at 6:56 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> 
> > On Thu, Nov 15, 2012 at 06:54:43PM +0400, Dmitry Vyukov wrote:
> > > Yes, I think people will search by "libsanitizer" (or "asan").
> > >
> > > Do I need to add Jakub Jelinek as reviewer as well?
> >
> > I can add myself after you commit it, or you can add me.
> >
> 
> 
> I've added you as well.
> If nobody objects to this version, I will commit it.
> 
> 
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 193530)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,8 @@
> +2012-11-15  Dmitry Vyukov  <dvyukov@google.com>
> +
> +        * MAINTAINERS: (libsanitizer, asan.c): Add myself
> + and Kostya Serebryany (kcc@google.com).

The ChangeLog entry is wrong, there should be a tab instead of 8
spaces at the beginning, the text is out of date to what you changed
and if you need more than one line, also the other lines need to be
indented by a single tab.

	Jakub
Jakub Jelinek - Nov. 15, 2012, 4:22 p.m.
On Thu, Nov 15, 2012 at 08:17:34PM +0400, Dmitry Vyukov wrote:
> +2012-11-15  Dmitry Vyukov  <dvyukov@google.com>
> +
> + * MAINTAINERS: (libsanitizer, asan.c): Add myself,
> + Kostya Serebryany (kcc@google.com) and
> + Jakub Jelinek (jakub@redhat.com).
> + Rename area for Dodji Seketeli (dodji@redhat.com).

If there are tabs (seems your mailer replaced them with spaces),
then this is ok.

	Jakub
Dmitriy Vyukov - Nov. 15, 2012, 4:38 p.m.
On Thu, Nov 15, 2012 at 8:22 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Thu, Nov 15, 2012 at 08:17:34PM +0400, Dmitry Vyukov wrote:
> > +2012-11-15  Dmitry Vyukov  <dvyukov@google.com>
> > +
> > + * MAINTAINERS: (libsanitizer, asan.c): Add myself,
> > + Kostya Serebryany (kcc@google.com) and
> > + Jakub Jelinek (jakub@redhat.com).
> > + Rename area for Dodji Seketeli (dodji@redhat.com).
>
> If there are tabs (seems your mailer replaced them with spaces),
> then this is ok.

Yeah, sorry, it's possible.
There are tabs in my change. Committed as 193536.

Patch

diff --git a/ChangeLog b/ChangeLog
index 8cd3b23..f035803 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@ 
+2012-11-15  Dodji Seketeli  <dodji@redhat.com>
+
+	* MAINTAINERS: (asan.c, related): Add myself.
+
 2012-11-14  Roland McGrath  <mcgrathr@google.com>
 
 	* configure.ac (ENABLE_GOLD): Consider *-*-nacl* targets ELF.
diff --git a/MAINTAINERS b/MAINTAINERS
index adec7a4..825c602 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -294,6 +294,7 @@  register allocation	Peter Bergner		bergner@vnet.ibm.com
 register allocation	Kenneth Zadeck		zadeck@naturalbridge.com
 register allocation	Seongbae Park		seongbae.park@gmail.com
 selective scheduling	Andrey Belevantsev	abel@ispras.ru
+asan.c, related         Dodji Seketeli		dodji@redhat.com
 
 Note that while reviewers can approve changes to parts of the compiler
 that they maintain, they still need approval for their own patches