Patchwork [3/6] data: klog.json: ACPI ACPI_ERROR messages

login
register
mail settings
Submitter Colin King
Date Nov. 15, 2012, 10:56 a.m.
Message ID <1352977013-19927-4-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/199246/
State Accepted
Headers show

Comments

Colin King - Nov. 15, 2012, 10:56 a.m.
From: Colin Ian King <colin.king@canonical.com>

ACPI ACPI_ERROR messages from video.c - rework these
messages, remove the need for the ACPI prefix in the error
as these messages are really quite unique in the kernel.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |   64 ++++++++++++++++++++++++++++----------------------------
 1 file changed, 32 insertions(+), 32 deletions(-)
Alex Hung - Nov. 22, 2012, 2:14 a.m.
On 11/15/2012 06:56 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ACPI ACPI_ERROR messages from video.c - rework these
> messages, remove the need for the ACPI prefix in the error
> as these messages are really quite unique in the kernel.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |   64 ++++++++++++++++++++++++++++----------------------------
>   1 file changed, 32 insertions(+), 32 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index d222911..98f67c4 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -78,6 +78,38 @@
>    [
>     {
>      "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
> +   "pattern": "Evaluating _BCM failed",
> +   "advice": "Could not set the brightness level, the ACPI control _BCM failed to execute correctly.",
> +   "label": "KlogAcpiBcmFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
> +   "pattern": "Current brightness invalid",
> +   "advice": "The ACPI video driver set the brightness level using the ACPI control _BCM, however the level used was not a known level (as returned by _BCL).",
> +   "label": "KlogAcpiInvalidBrightness"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "Too many duplicates in _BCL package",
> +   "advice": "ACPI method _BCL (Query List of Brightness Control Levels Supported) contains too many duplicated brightness levels in the returned package and this is non-standard.",
> +   "label": "KlogAcpiBclPackageContainsDuplicates"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "Found unordered _BCL package",
> +   "advice": "ACPI method _BCL (Query List of Brightness Control Levels Supported) has a maximum brightness value which is not the last value in the returned package. Values returned must be in ascending order.",
> +   "label": "KlogAcpiBclUnorderedPackage"
> +  },
> +  {
> +   "compare_mode": "string",
>      "log_level": "LOG_LEVEL_MEDIUM",
>      "tag": "FWTS_TAG_ACPI",
>      "pattern": "ACPI Subsystem is already terminated",
> @@ -1455,14 +1487,6 @@
>     {
>      "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
> -   "pattern": "ACPI Error.*Current brightness invalid",
> -   "advice": "ACPI video driver has encountered a brightness level that is outside the expected range.",
> -   "label": "KlogAcpiCurrentBrightnessInvalid"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_NAMESPACE_LOOKUP",
>      "pattern": "ACPI Error.*Namespace lookup failure, AE_ALREADY_EXISTS",
>      "advice": "",
> @@ -1751,14 +1775,6 @@
>     {
>      "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
> -   "pattern": "ACPI Error.*Evaluating _BCM failed",
> -   "advice": "The ACPI engine has failed to execute the _BCM Brightness Control Method.  This will result in possibly failing to set the display brightness level.",
> -   "label": "KlogAcpiEvaluateBcmFailed"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_EVAL",
>      "pattern": "ACPI (Warning|Error).*Evaluating .* failed",
>      "advice": "Executing the ACPI Method leaded in an execution failure. This needs investigating.",
> @@ -1855,22 +1871,6 @@
>     {
>      "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
> -   "pattern": "ACPI Error.*Found unordered _BCL package",
> -   "advice": "Method _BCL (Query List of Brightness Control Levels Supported) has a maximum brightness value which is not the last value in the returned package. Values returned must be in ascending order.",
> -   "label": "KlogAcpiBclUnorderedPackage"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
> -   "pattern": "ACPI Error.*Too many duplicates in _BCL package",
> -   "advice": "Method _BCL (Query List of Brightness Control Levels Supported) contains too many duplicated brightness levels in the returned package and this is non-standard.",
> -   "label": "KlogAcpiBclPackageContainsDuplicates"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI",
>      "pattern": "ACPI Warning.*Could not enable fixed event",
>      "advice": "",
>
Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - Nov. 22, 2012, 5:45 a.m.
On Thu, Nov 15, 2012 at 6:56 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ACPI ACPI_ERROR messages from video.c - rework these
> messages, remove the need for the ACPI prefix in the error
> as these messages are really quite unique in the kernel.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |   64 ++++++++++++++++++++++++++++----------------------------
>  1 file changed, 32 insertions(+), 32 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index d222911..98f67c4 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -78,6 +78,38 @@
>   [
>    {
>     "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
> +   "pattern": "Evaluating _BCM failed",
> +   "advice": "Could not set the brightness level, the ACPI control _BCM failed to execute correctly.",
> +   "label": "KlogAcpiBcmFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
> +   "pattern": "Current brightness invalid",
> +   "advice": "The ACPI video driver set the brightness level using the ACPI control _BCM, however the level used was not a known level (as returned by _BCL).",
> +   "label": "KlogAcpiInvalidBrightness"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "Too many duplicates in _BCL package",
> +   "advice": "ACPI method _BCL (Query List of Brightness Control Levels Supported) contains too many duplicated brightness levels in the returned package and this is non-standard.",
> +   "label": "KlogAcpiBclPackageContainsDuplicates"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "Found unordered _BCL package",
> +   "advice": "ACPI method _BCL (Query List of Brightness Control Levels Supported) has a maximum brightness value which is not the last value in the returned package. Values returned must be in ascending order.",
> +   "label": "KlogAcpiBclUnorderedPackage"
> +  },
> +  {
> +   "compare_mode": "string",
>     "log_level": "LOG_LEVEL_MEDIUM",
>     "tag": "FWTS_TAG_ACPI",
>     "pattern": "ACPI Subsystem is already terminated",
> @@ -1455,14 +1487,6 @@
>    {
>     "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
> -   "pattern": "ACPI Error.*Current brightness invalid",
> -   "advice": "ACPI video driver has encountered a brightness level that is outside the expected range.",
> -   "label": "KlogAcpiCurrentBrightnessInvalid"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI_NAMESPACE_LOOKUP",
>     "pattern": "ACPI Error.*Namespace lookup failure, AE_ALREADY_EXISTS",
>     "advice": "",
> @@ -1751,14 +1775,6 @@
>    {
>     "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
> -   "pattern": "ACPI Error.*Evaluating _BCM failed",
> -   "advice": "The ACPI engine has failed to execute the _BCM Brightness Control Method.  This will result in possibly failing to set the display brightness level.",
> -   "label": "KlogAcpiEvaluateBcmFailed"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI_EVAL",
>     "pattern": "ACPI (Warning|Error).*Evaluating .* failed",
>     "advice": "Executing the ACPI Method leaded in an execution failure. This needs investigating.",
> @@ -1855,22 +1871,6 @@
>    {
>     "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
> -   "pattern": "ACPI Error.*Found unordered _BCL package",
> -   "advice": "Method _BCL (Query List of Brightness Control Levels Supported) has a maximum brightness value which is not the last value in the returned package. Values returned must be in ascending order.",
> -   "label": "KlogAcpiBclUnorderedPackage"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
> -   "pattern": "ACPI Error.*Too many duplicates in _BCL package",
> -   "advice": "Method _BCL (Query List of Brightness Control Levels Supported) contains too many duplicated brightness levels in the returned package and this is non-standard.",
> -   "label": "KlogAcpiBclPackageContainsDuplicates"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI",
>     "pattern": "ACPI Warning.*Could not enable fixed event",
>     "advice": "",
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index d222911..98f67c4 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -78,6 +78,38 @@ 
  [
   {
    "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
+   "pattern": "Evaluating _BCM failed",
+   "advice": "Could not set the brightness level, the ACPI control _BCM failed to execute correctly.",
+   "label": "KlogAcpiBcmFailed"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
+   "pattern": "Current brightness invalid",
+   "advice": "The ACPI video driver set the brightness level using the ACPI control _BCM, however the level used was not a known level (as returned by _BCL).",
+   "label": "KlogAcpiInvalidBrightness"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_MEDIUM",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "Too many duplicates in _BCL package",
+   "advice": "ACPI method _BCL (Query List of Brightness Control Levels Supported) contains too many duplicated brightness levels in the returned package and this is non-standard.",
+   "label": "KlogAcpiBclPackageContainsDuplicates"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_MEDIUM",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "Found unordered _BCL package",
+   "advice": "ACPI method _BCL (Query List of Brightness Control Levels Supported) has a maximum brightness value which is not the last value in the returned package. Values returned must be in ascending order.",
+   "label": "KlogAcpiBclUnorderedPackage"
+  },
+  {
+   "compare_mode": "string",
    "log_level": "LOG_LEVEL_MEDIUM",
    "tag": "FWTS_TAG_ACPI",
    "pattern": "ACPI Subsystem is already terminated",
@@ -1455,14 +1487,6 @@ 
   {
    "compare_mode": "regex",
    "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
-   "pattern": "ACPI Error.*Current brightness invalid",
-   "advice": "ACPI video driver has encountered a brightness level that is outside the expected range.",
-   "label": "KlogAcpiCurrentBrightnessInvalid"
-  },
-  {
-   "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI_NAMESPACE_LOOKUP",
    "pattern": "ACPI Error.*Namespace lookup failure, AE_ALREADY_EXISTS",
    "advice": "",
@@ -1751,14 +1775,6 @@ 
   {
    "compare_mode": "regex",
    "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
-   "pattern": "ACPI Error.*Evaluating _BCM failed",
-   "advice": "The ACPI engine has failed to execute the _BCM Brightness Control Method.  This will result in possibly failing to set the display brightness level.",
-   "label": "KlogAcpiEvaluateBcmFailed"
-  },
-  {
-   "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI_EVAL",
    "pattern": "ACPI (Warning|Error).*Evaluating .* failed",
    "advice": "Executing the ACPI Method leaded in an execution failure. This needs investigating.",
@@ -1855,22 +1871,6 @@ 
   {
    "compare_mode": "regex",
    "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
-   "pattern": "ACPI Error.*Found unordered _BCL package",
-   "advice": "Method _BCL (Query List of Brightness Control Levels Supported) has a maximum brightness value which is not the last value in the returned package. Values returned must be in ascending order.",
-   "label": "KlogAcpiBclUnorderedPackage"
-  },
-  {
-   "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_ACPI_BRIGHTNESS",
-   "pattern": "ACPI Error.*Too many duplicates in _BCL package",
-   "advice": "Method _BCL (Query List of Brightness Control Levels Supported) contains too many duplicated brightness levels in the returned package and this is non-standard.",
-   "label": "KlogAcpiBclPackageContainsDuplicates"
-  },
-  {
-   "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI",
    "pattern": "ACPI Warning.*Could not enable fixed event",
    "advice": "",