Patchwork mtd: nand: typo in nand_id_has_period() comments

login
register
mail settings
Submitter Brian Norris
Date Nov. 15, 2012, 5:54 a.m.
Message ID <1352958860-16430-1-git-send-email-computersforpeace@gmail.com>
Download mbox | patch
Permalink /patch/199186/
State New
Headers show

Comments

Brian Norris - Nov. 15, 2012, 5:54 a.m.
The simple example provided in the comments for nand_id_has_period()
actually has a period of 3, not 2. Silly mistake...

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/mtd/nand/nand_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Brian Norris - Dec. 11, 2012, 9:44 p.m.
On Wed, Nov 14, 2012 at 9:54 PM, Brian Norris
<computersforpeace@gmail.com> wrote:
> The simple example provided in the comments for nand_id_has_period()
> actually has a period of 3, not 2. Silly mistake...
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>

Bump?
Artem Bityutskiy - Dec. 13, 2012, 11:38 a.m.
On Tue, 2012-12-11 at 13:44 -0800, Brian Norris wrote:
> On Wed, Nov 14, 2012 at 9:54 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
> > The simple example provided in the comments for nand_id_has_period()
> > actually has a period of 3, not 2. Silly mistake...
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> 
> Bump?

Ouch! Pushed to l2, thanks!

Patch

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 4569174..c2af1e8 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2913,7 +2913,7 @@  static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip,
  *
  * Check if an ID string is repeated within a given sequence of bytes at
  * specific repetition interval period (e.g., {0x20,0x01,0x7F,0x20} has a
- * period of 2). This is a helper function for nand_id_len(). Returns non-zero
+ * period of 3). This is a helper function for nand_id_len(). Returns non-zero
  * if the repetition has a period of @period; otherwise, returns zero.
  */
 static int nand_id_has_period(u8 *id_data, int arrlen, int period)