Patchwork [3.5.yuz,extended,stable] Patch "iscsit: remove incorrect unlock in" has been added to staging queue

mail settings
Submitter Herton Ronaldo Krzesinski
Date Nov. 15, 2012, 5:48 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/199159/
State New
Headers show


Herton Ronaldo Krzesinski - Nov. 15, 2012, 5:48 a.m.
This is a note to let you know that I have just added a patch titled

    iscsit: remove incorrect unlock in

to the linux-3.5.y-queue branch of the 3.5.yuz extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.yuz tree, see



From 6342bfa35bf7a7891483adda7b4d8c2e3eb16c8d Mon Sep 17 00:00:00 2001
From: Christoph Hellwig <>
Date: Wed, 26 Sep 2012 08:00:37 -0400
Subject: [PATCH] iscsit: remove incorrect unlock in

commit 904753da183566c71211d23c169a80184648c121 upstream.

Fix a potential multiple spin-unlock -> deadlock scenario during the
overflow check within iscsit_build_sendtargets_resp() as found by
sparse static checking.

Signed-off-by: Christoph Hellwig <>
Signed-off-by: Nicholas Bellinger <>
Signed-off-by: Herton Ronaldo Krzesinski <>
 drivers/target/iscsi/iscsi_target.c |    1 -
 1 file changed, 1 deletion(-)



diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index d3114d1..6d1d906 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -3269,7 +3269,6 @@  static int iscsit_build_sendtargets_response(struct iscsi_cmd *cmd)
 		len += 1;

 		if ((len + payload_len) > buffer_len) {
-			spin_unlock(&tiqn->tiqn_tpg_lock);
 			end_of_buf = 1;
 			goto eob;