Patchwork [2/2] kvm: Actually remove software breakpoints from list on cleanup

login
register
mail settings
Submitter Marcelo Tosatti
Date Nov. 15, 2012, 12:11 a.m.
Message ID <78021d6d8dc50ed4d67442c3ca11eab78220e9ef.1352938305.git.mtosatti@redhat.com>
Download mbox | patch
Permalink /patch/199095/
State New
Headers show

Comments

Marcelo Tosatti - Nov. 15, 2012, 12:11 a.m.
From: Jan Kiszka <jan.kiszka@siemens.com>

So far we only removed them from the guest, leaving its states in the
list. This made it impossible for gdb to re-enable breakpoints on the
same address after re-attaching.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
 kvm-all.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Patch

diff --git a/kvm-all.c b/kvm-all.c
index b6d0483..3bc3347 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -1905,6 +1905,8 @@  void kvm_remove_all_breakpoints(CPUArchState *current_env)
                 }
             }
         }
+        QTAILQ_REMOVE(&s->kvm_sw_breakpoints, bp, entry);
+        g_free(bp);
     }
     kvm_arch_remove_all_hw_breakpoints();