Patchwork [m68k] add multiarch definitions for m68k-linux-gnu

login
register
mail settings
Submitter Matthias Klose
Date Nov. 14, 2012, 11:33 p.m.
Message ID <50A42A4C.6010706@ubuntu.com>
Download mbox | patch
Permalink /patch/199076/
State New
Headers show

Comments

Matthias Klose - Nov. 14, 2012, 11:33 p.m.
Am 14.11.2012 23:39, schrieb Joseph S. Myers:
> On Wed, 14 Nov 2012, Matthias Klose wrote:
> 
>> The following patch adds the multiarch definitions for m68k-linux-gnu. Tested
>> using a Debian/Ubuntu package build. Ok for the trunk?
>>
>> Here, I'm unsure if the definition needs to be further constrained.
> 
> Classix m68k and ColdFire need different multiarch names; you need to 
> avoid using a name for one on a compiler configured for the other.  (I 
> think any configuration will always be --with-arch=m68k or --with-arch=cf 
> so you should only need to consider M68K_ARCH rather than having 
> per-multilib settings.)

thanks for the pointer. For now, I set it just for the classic m68k.

  Matthias
Matthias Klose - Nov. 21, 2012, 3:50 a.m.
ping, adding the m68k port maintainers

Am 15.11.2012 00:33, schrieb Matthias Klose:
> Am 14.11.2012 23:39, schrieb Joseph S. Myers:
>> On Wed, 14 Nov 2012, Matthias Klose wrote:
>>
>>> The following patch adds the multiarch definitions for m68k-linux-gnu. Tested
>>> using a Debian/Ubuntu package build. Ok for the trunk?
>>>
>>> Here, I'm unsure if the definition needs to be further constrained.
>>
>> Classix m68k and ColdFire need different multiarch names; you need to 
>> avoid using a name for one on a compiler configured for the other.  (I 
>> think any configuration will always be --with-arch=m68k or --with-arch=cf 
>> so you should only need to consider M68K_ARCH rather than having 
>> per-multilib settings.)
> 
> thanks for the pointer. For now, I set it just for the classic m68k.
> 
>   Matthias
> 
>
Andreas Schwab - Nov. 21, 2012, 5:46 p.m.
Matthias Klose <doko@ubuntu.com> writes:

> 2012-11-14  Matthias Klose  <doko@ubuntu.com>
>
> 	* config/m68k/t-linux: Define MULTIARCH_DIRNAME for classic m68k.

Ok, thanks.

Andreas.

Patch

2012-11-14  Matthias Klose  <doko@ubuntu.com>

	* config/m68k/t-linux: Define MULTIARCH_DIRNAME for classic m68k.

Index: config/m68k/t-linux
===================================================================
--- config/m68k/t-linux	(revision 193510)
+++ config/m68k/t-linux	(working copy)
@@ -19,6 +19,10 @@ 
 # Only include multilibs for 680x0 and ColdFire CPUs with an MMU.
 M68K_MLIB_CPU += && ((CPU ~ "^m680") || (CPU ~ "^mcf")) && (FLAGS ~ "FL_MMU")
 
+ifeq ($(M68K_ARCH),m68k)
+MULTIARCH_DIRNAME = $(call if_multiarch,m68k-linux-gnu)
+endif
+
 # This rule uses MULTILIB_MATCHES to generate a definition of
 # SYSROOT_SUFFIX_SPEC.
 sysroot-suffix.h: $(srcdir)/config/m68k/print-sysroot-suffix.sh