From patchwork Wed Nov 14 16:39:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paolo Carlini X-Patchwork-Id: 198960 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id BACA72C00AA for ; Thu, 15 Nov 2012 03:39:36 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1353515977; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Message-ID:Date:From:User-Agent:MIME-Version: To:CC:Subject:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=+P/2dvMWNIvQ6bUBukjmqE3ubCA=; b=lTJodbwvWOS2Qvz 088iVvzSGTA3iewgKtG+vPBqYubDcWP13lBbHGX5Lgfl4BQ5hQJAIxqGzQkrOO70 I1gBUjbCj6yDfn7cFCHxC3kRme4ugKEu3eDqVKL26hug+KRzoP1CV1n7t8Sw0oM1 cx/2diqNTz04E0JJq+6/gPhb4byI= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=ZZ2tHSsP6yAlCEyZQ7KB3pfA8Pap1jUezpx9oM85mTcyZurv/Rzdgb6l2s+Yya +EwzSgvZrHDPoRR22FQ3w/uW3zPON/9Z70yhyAJTUsES2QYrtYoBrhb6S4aTNoJv SRyLTUmBy8oDYI6Lb4CNv9KJSqP4Mm/yZ34DzbCLs5B84=; Received: (qmail 22923 invoked by alias); 14 Nov 2012 16:39:23 -0000 Received: (qmail 22694 invoked by uid 22791); 14 Nov 2012 16:39:21 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_HOSTKARMA_NO, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Nov 2012 16:39:18 +0000 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qAEGdGEd015614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 14 Nov 2012 16:39:17 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qAEGdFc7002647 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 14 Nov 2012 16:39:16 GMT Received: from abhmt101.oracle.com (abhmt101.oracle.com [141.146.116.53]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qAEGdFkj003281; Wed, 14 Nov 2012 10:39:15 -0600 Received: from [192.168.1.4] (/79.47.195.242) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 14 Nov 2012 08:39:15 -0800 Message-ID: <50A3C930.3050702@oracle.com> Date: Wed, 14 Nov 2012 17:39:12 +0100 From: Paolo Carlini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org" CC: Jason Merrill Subject: [C++ Patch] PR 55323 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, in this ICE on illegal what happens is the following: finish_mem_initializers calls check_for_bare_parameter_packs which errors out with "parameter packs not expanded with ‘...’" and returns true, thus the former does TREE_VALUE (mem) = error_mark_node. Eventually, emit_mem_initializers calls expand_aggr_init_1 with this error_mark_node as 'arguments' which hits the gcc_assert for init != error_mark_node. A safe fix, which passes testing on x86_64-linux, seems just skipping the error_mark_node. I also considered simply returning, but that would certainly change the current behavior in terms of warnings produced for other bases when arguments == NULL_TREE. Thanks, Paolo. ///////////////////// /cp 2012-11-14 Paolo Carlini PR c++/55323 * init.c (emit_mem_initializers): Skip arguments == error_mark_node. /testsuite 2012-11-14 Paolo Carlini PR c++/55323 * g++.dg/cpp0x/vt-55323.C: New. Index: cp/init.c =================================================================== --- cp/init.c (revision 193495) +++ cp/init.c (working copy) @@ -1047,12 +1047,17 @@ emit_mem_initializers (tree mem_inits) in_base_initializer = 1; /* Initialize base classes. */ - while (mem_inits - && TREE_CODE (TREE_PURPOSE (mem_inits)) != FIELD_DECL) + for (; (mem_inits + && TREE_CODE (TREE_PURPOSE (mem_inits)) != FIELD_DECL); + mem_inits = TREE_CHAIN (mem_inits)) { tree subobject = TREE_PURPOSE (mem_inits); tree arguments = TREE_VALUE (mem_inits); + /* We will already have issued an error message. */ + if (arguments == error_mark_node) + continue; + if (arguments == NULL_TREE) { /* If these initializations are taking place in a copy constructor, @@ -1085,8 +1090,6 @@ emit_mem_initializers (tree mem_inits) tf_warning_or_error); expand_cleanup_for_base (subobject, NULL_TREE); } - - mem_inits = TREE_CHAIN (mem_inits); } in_base_initializer = 0; Index: testsuite/g++.dg/cpp0x/vt-55323.C =================================================================== --- testsuite/g++.dg/cpp0x/vt-55323.C (revision 0) +++ testsuite/g++.dg/cpp0x/vt-55323.C (working copy) @@ -0,0 +1,12 @@ +// { dg-options "-std=c++11" } + +struct foo { + foo(int a, float b); +}; + +struct bar : foo { + template + bar(Args&&... args) : foo(2, args){} // { dg-error "parameter packs" } +}; + +bar b(2,1.);