Patchwork osdep: Move qemu_{open,close}() prototypes

login
register
mail settings
Submitter Andreas Färber
Date Nov. 14, 2012, 3:46 p.m.
Message ID <1352907967-30647-1-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/198949/
State New
Headers show

Comments

Andreas Färber - Nov. 14, 2012, 3:46 p.m.
They are implemented in osdep.c, so keep the prototypes in osdep.h.

Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Cc: Eduardo Habkost <ehabkost@redhat.com>
---
 osdep.h       |    3 +++
 qemu-common.h |    2 --
 2 Dateien geändert, 3 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)
Eduardo Habkost - Nov. 14, 2012, 4:04 p.m.
On Wed, Nov 14, 2012 at 04:46:07PM +0100, Andreas Färber wrote:
> They are implemented in osdep.c, so keep the prototypes in osdep.h.
> 
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> Cc: Eduardo Habkost <ehabkost@redhat.com>

Acked-by: Eduardo Habkost <ehabkost@redhat.com>


> ---
>  osdep.h       |    3 +++
>  qemu-common.h |    2 --
>  2 Dateien geändert, 3 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)
> 
> diff --git a/osdep.h b/osdep.h
> index 585e2c1..87d3b9c 100644
> --- a/osdep.h
> +++ b/osdep.h
> @@ -136,6 +136,9 @@ void qemu_vfree(void *ptr);
>  
>  int qemu_madvise(void *addr, size_t len, int advice);
>  
> +int qemu_open(const char *name, int flags, ...);
> +int qemu_close(int fd);
> +
>  #if defined(__HAIKU__) && defined(__i386__)
>  #define FMT_pid "%ld"
>  #elif defined(WIN64)
> diff --git a/qemu-common.h b/qemu-common.h
> index 9112e2d..cef264c 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -217,8 +217,6 @@ const char *path(const char *pathname);
>  
>  void *qemu_oom_check(void *ptr);
>  
> -int qemu_open(const char *name, int flags, ...);
> -int qemu_close(int fd);
>  ssize_t qemu_write_full(int fd, const void *buf, size_t count)
>      QEMU_WARN_UNUSED_RESULT;
>  ssize_t qemu_send_full(int fd, const void *buf, size_t count, int flags)
> -- 
> 1.7.10.4
>

Patch

diff --git a/osdep.h b/osdep.h
index 585e2c1..87d3b9c 100644
--- a/osdep.h
+++ b/osdep.h
@@ -136,6 +136,9 @@  void qemu_vfree(void *ptr);
 
 int qemu_madvise(void *addr, size_t len, int advice);
 
+int qemu_open(const char *name, int flags, ...);
+int qemu_close(int fd);
+
 #if defined(__HAIKU__) && defined(__i386__)
 #define FMT_pid "%ld"
 #elif defined(WIN64)
diff --git a/qemu-common.h b/qemu-common.h
index 9112e2d..cef264c 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -217,8 +217,6 @@  const char *path(const char *pathname);
 
 void *qemu_oom_check(void *ptr);
 
-int qemu_open(const char *name, int flags, ...);
-int qemu_close(int fd);
 ssize_t qemu_write_full(int fd, const void *buf, size_t count)
     QEMU_WARN_UNUSED_RESULT;
 ssize_t qemu_send_full(int fd, const void *buf, size_t count, int flags)