Patchwork [v2,1/2] ARM: mx27_3ds: Add VPU support

login
register
mail settings
Submitter Fabio Estevam
Date Nov. 14, 2012, 1:19 p.m.
Message ID <1352899174-28022-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/198907/
State New
Headers show

Comments

Fabio Estevam - Nov. 14, 2012, 1:19 p.m.
mx27 has a VPU (Video Processing Unit) block that allows doing H264/MPEG4
decoding and encoding in hardware.

Add support for it.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Do not allocate the coda buffers explicetely

 arch/arm/mach-imx/mach-mx27_3ds.c |    1 +
 1 file changed, 1 insertion(+)
Sascha Hauer - Nov. 14, 2012, 2:34 p.m.
Hi Fabio,

On Wed, Nov 14, 2012 at 11:19:33AM -0200, Fabio Estevam wrote:
> mx27 has a VPU (Video Processing Unit) block that allows doing H264/MPEG4
> decoding and encoding in hardware.
> 
> Add support for it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Do not allocate the coda buffers explicetely
> 
>  arch/arm/mach-imx/mach-mx27_3ds.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-imx/mach-mx27_3ds.c b/arch/arm/mach-imx/mach-mx27_3ds.c
> index d0e547f..e37a114 100644
> --- a/arch/arm/mach-imx/mach-mx27_3ds.c
> +++ b/arch/arm/mach-imx/mach-mx27_3ds.c
> @@ -531,6 +531,7 @@ static void __init mx27pdk_init(void)
>  	imx27_add_imx_ssi(0, &mx27_3ds_ssi_pdata);
>  
>  	imx_add_platform_device("imx_mc13783", 0, NULL, 0, NULL, 0);
> +	imx27_add_coda();

Why in the board? It's always present so I would register it in the SoC.

Sascha
Eric Benard - Nov. 14, 2012, 3:44 p.m.
Hi Sascha,

Le Wed, 14 Nov 2012 15:34:00 +0100,
Sascha Hauer <s.hauer@pengutronix.de> a écrit :
> On Wed, Nov 14, 2012 at 11:19:33AM -0200, Fabio Estevam wrote:
> > mx27 has a VPU (Video Processing Unit) block that allows doing H264/MPEG4
> > decoding and encoding in hardware.
> > 
> > Add support for it.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> > +	imx27_add_coda();
> 
> Why in the board? It's always present so I would register it in the SoC.
> 
MCIMX27L* dosn't have the VPU. No idea how will behave the probe in
that case.

Eruc

Patch

diff --git a/arch/arm/mach-imx/mach-mx27_3ds.c b/arch/arm/mach-imx/mach-mx27_3ds.c
index d0e547f..e37a114 100644
--- a/arch/arm/mach-imx/mach-mx27_3ds.c
+++ b/arch/arm/mach-imx/mach-mx27_3ds.c
@@ -531,6 +531,7 @@  static void __init mx27pdk_init(void)
 	imx27_add_imx_ssi(0, &mx27_3ds_ssi_pdata);
 
 	imx_add_platform_device("imx_mc13783", 0, NULL, 0, NULL, 0);
+	imx27_add_coda();
 }
 
 static void __init mx27pdk_timer_init(void)