From patchwork Wed Nov 14 12:57:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [2/2] ping: Don't free an unintialized value. From: Jan Synacek X-Patchwork-Id: 198893 X-Patchwork-Delegate: davem@davemloft.net Message-Id: <1352897836-17603-3-git-send-email-jsynacek@redhat.com> To: yoshfuji@linux-ipv6.org Cc: netdev@vger.kernel.org, Jan Synacek Date: Wed, 14 Nov 2012 13:57:16 +0100 --- ping.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ping.c b/ping.c index fe9ff8a..9de3d08 100644 --- a/ping.c +++ b/ping.c @@ -122,7 +122,7 @@ main(int argc, char **argv) u_char *packet; char *target; #ifdef USE_IDN - char *hnamebuf; + char *hnamebuf = NULL; #else char hnamebuf[MAX_HOSTNAMELEN]; #endif @@ -263,8 +263,10 @@ main(int argc, char **argv) #ifdef USE_IDN int rc; - free(hnamebuf); - hnamebuf = NULL; + if (hnamebuf) { + free(hnamebuf); + hnamebuf = NULL; + } rc = idna_to_ascii_lz(target, &idn, 0); if (rc != IDNA_SUCCESS) {