Patchwork [10/10] Import the asan runtime library into GCC tree

login
register
mail settings
Submitter H.J. Lu
Date Nov. 14, 2012, 11:11 a.m.
Message ID <CAMe9rOq4ExMswi7jmjHKG=5vuurvXCAry3u9mk9S6cou=0tKng@mail.gmail.com>
Download mbox | patch
Permalink /patch/198874/
State New
Headers show

Comments

H.J. Lu - Nov. 14, 2012, 11:11 a.m.
On Mon, Nov 12, 2012 at 10:59 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Nov 12, 2012 at 3:47 AM, Dodji Seketeli <dodji@seketeli.org> wrote:
>> Diego Novillo <dnovillo@google.com> writes:
>>
>>> On 2012-11-02 16:10 , Dodji Seketeli wrote:
>>>
>>>>          * configure.ac: Add libsanitizer to target_libraries.
>>>>      * Makefile.def: Ditto.
>>>>      * configure: Regenerate.
>>>>      * Makefile.in: Regenerate.
>>>>      * libsanitizer: New directory for asan runtime.  Contains an empty
>>>>      tsan directory.
>>>>
>>>> gcc:
>>>>      * gcc.c (LINK_COMMAND_SPEC): Add -lasan to link command
>>>>      if -faddress-sanitizer is on.
>>>
>>> OK with Jakub's comments addressed.
>>>
>>> References to -fasan in diagnostics should be replaced.  But there's
>>> been another flag name change upstream, so let's do it together with
>>> the new flag names.
>>
>> Done.   This also addresses the comment later made by Tobias below:
>>
>> Tobias Burnus <burnus@net-b.de> writes:
>>
>>> Other issues:
>>
>>> * Probably fixed on the branch: gcc/gcc.c still has "fasan" instead of
>>> "faddress-sanitizer" for the spec:
>>> +    %{fasan:-lasan}
>>
>> Below is a link to the updated patch.
>>
>> This patch imports the runtime library in the GCC tree, ensures that
>> -lasan is passed to the linker when -faddress-sanitizer is used and
>> sets up the build system accordingly.
>>
>>      * configure.ac: Add libsanitizer to target_libraries.
>>         * Makefile.def: Ditto.
>>         * configure: Regenerate.
>>         * Makefile.in: Regenerate.
>>         * libsanitizer: New directory for asan runtime.  Contains an empty
>>         tsan directory.
>>
>> gcc:
>>         * gcc.c (LINK_COMMAND_SPEC): Add -laddress-sanitizer to link command
>>         if -faddress-sanitizer is on.
>>
>> libsanitizer:
>>
>>         Initial checkin: migrate asan runtime from llvm.
>>
>> http://people.redhat.com/~dseketel/gcc/patches/0011-Import-the-asan-runtime-library-into-GCC-tree.patch
>>
>> --
>>                 Dodji
>
> I checked in this patch to add libsanitizer generated files.
>
> --
> H.J.
> ---
> diff --git a/contrib/ChangeLog b/contrib/ChangeLog
> index ef5d6f6..233870d 100644
> --- a/contrib/ChangeLog
> +++ b/contrib/ChangeLog
> @@ -1,3 +1,7 @@
> +2012-11-12  H.J. Lu  <hongjiu.lu@intel.com>
> +
> +       * gcc_update: Add libsanitizer generated files.
> +
>  2012-11-05  Lawrence Crowl  <crowl@google.com>
>
>         * compare_two_ftime_report_sets: New.
> diff --git a/contrib/gcc_update b/contrib/gcc_update
> index 02897ab..d9c2dfb 100755
> --- a/contrib/gcc_update
> +++ b/contrib/gcc_update
> @@ -149,6 +149,9 @@ libatomic/Makefile.in: libatomic/Makefile.am
> libatomic/aclocal.m4
>  libatomic/testsuite/Makefile.in: libatomic/testsuite/Makefile.am
> libatomic/aclocal.m4
>  libatomic/configure: libatomic/configure.ac libatomic/aclocal.m4
>  libatomic/auto-config.h.in: libatomic/configure.ac libatomic/aclocal.m4
> +libsanitizer/aclocal.m4: libsanitizer/configure.ac
> +libsanitizer/Makefile.in: libsanitizer/Makefile.am libsanitizer/aclocal.m4
> +libsanitizer/configure: libsanitizer/configure.ac libsanitizer/aclocal.m4
>  # Top level
>  Makefile.in: Makefile.tpl Makefile.def
>  configure: configure.ac config/acx.m4

I checked in this to update libsanitizer generated files.
H.J. Lu - Nov. 14, 2012, 11:42 a.m.
On Wed, Nov 14, 2012 at 3:11 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Nov 12, 2012 at 10:59 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Mon, Nov 12, 2012 at 3:47 AM, Dodji Seketeli <dodji@seketeli.org> wrote:
>>> Diego Novillo <dnovillo@google.com> writes:
>>>
>>>> On 2012-11-02 16:10 , Dodji Seketeli wrote:
>>>>
>>>>>          * configure.ac: Add libsanitizer to target_libraries.
>>>>>      * Makefile.def: Ditto.
>>>>>      * configure: Regenerate.
>>>>>      * Makefile.in: Regenerate.
>>>>>      * libsanitizer: New directory for asan runtime.  Contains an empty
>>>>>      tsan directory.
>>>>>
>>>>> gcc:
>>>>>      * gcc.c (LINK_COMMAND_SPEC): Add -lasan to link command
>>>>>      if -faddress-sanitizer is on.
>>>>
>>>> OK with Jakub's comments addressed.
>>>>
>>>> References to -fasan in diagnostics should be replaced.  But there's
>>>> been another flag name change upstream, so let's do it together with
>>>> the new flag names.
>>>
>>> Done.   This also addresses the comment later made by Tobias below:
>>>
>>> Tobias Burnus <burnus@net-b.de> writes:
>>>
>>>> Other issues:
>>>
>>>> * Probably fixed on the branch: gcc/gcc.c still has "fasan" instead of
>>>> "faddress-sanitizer" for the spec:
>>>> +    %{fasan:-lasan}
>>>
>>> Below is a link to the updated patch.
>>>
>>> This patch imports the runtime library in the GCC tree, ensures that
>>> -lasan is passed to the linker when -faddress-sanitizer is used and
>>> sets up the build system accordingly.
>>>
>>>      * configure.ac: Add libsanitizer to target_libraries.
>>>         * Makefile.def: Ditto.
>>>         * configure: Regenerate.
>>>         * Makefile.in: Regenerate.
>>>         * libsanitizer: New directory for asan runtime.  Contains an empty
>>>         tsan directory.
>>>
>>> gcc:
>>>         * gcc.c (LINK_COMMAND_SPEC): Add -laddress-sanitizer to link command
>>>         if -faddress-sanitizer is on.
>>>
>>> libsanitizer:
>>>
>>>         Initial checkin: migrate asan runtime from llvm.
>>>
>>> http://people.redhat.com/~dseketel/gcc/patches/0011-Import-the-asan-runtime-library-into-GCC-tree.patch
>>>

I renamed ChangeLog.asan to ChangeLog.

Patch

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 193496)
+++ ChangeLog	(working copy)
@@ -1,3 +1,7 @@ 
+2012-11-14  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* gcc_update: Update libsanitizer generated files.
+
 2012-11-12  Tobias Burnus  <burnus@net-b.de>

 	* gcc_update: Add libquadmath generated files.
Index: gcc_update
===================================================================
--- gcc_update	(revision 193496)
+++ gcc_update	(working copy)
@@ -152,9 +152,12 @@ 
 libatomic/testsuite/Makefile.in: libatomic/testsuite/Makefile.am
libatomic/aclocal.m4
 libatomic/configure: libatomic/configure.ac libatomic/aclocal.m4
 libatomic/auto-config.h.in: libatomic/configure.ac libatomic/aclocal.m4
-libsanitizer/aclocal.m4: libsanitizer/configure.ac
+libsanitizer/aclocal.m4: libsanitizer/configure.ac libsanitizer/acinclude.m4
 libsanitizer/Makefile.in: libsanitizer/Makefile.am libsanitizer/aclocal.m4
 libsanitizer/configure: libsanitizer/configure.ac libsanitizer/aclocal.m4
+libsanitizer/asan/Makefile.in: libsanitizer/asan/Makefile.am
libsanitizer/aclocal.m4
+libsanitizer/interception/Makefile.in:
libsanitizer/interception/Makefile.am libsanitizer/aclocal.m4
+libsanitizer/sanitizer_common/Makefile.in: