| Message ID | CANLjY-=3Gbio6nzUPhhevDHV7cUN=6Vigooe9nSf-RnGCqnjog@mail.gmail.com |
|---|---|
| State | Accepted |
| Commit | a9130ff13b19 |
| Headers | show |
On Wed, Nov 14, 2012 at 02:06:18PM +1300, Michael Hope wrote: > On 14 November 2012 13:30, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > On Wednesday 14 November 2012 Michael Hope wrote: > >> It turns out that GCC and the libraries are being built without > >> optimisation. ... > --- a/scripts/crosstool-NG.sh.in Fri Nov 09 18:22:31 2012 +0100 > +++ b/scripts/crosstool-NG.sh.in Wed Nov 14 13:48:18 2012 +1300 > @@ -494,7 +494,9 @@ > fi > > # Help gcc > - CT_CFLAGS_FOR_HOST= > + # Explicitly optimise, else the lines below will overide the > + # package's default optimisation flags > + CT_CFLAGS_FOR_HOST="-O2 -g" > [ "${CT_USE_PIPES}" = "y" ] && CT_CFLAGS_FOR_HOST+=" -pipe" > CT_CFLAGS_FOR_HOST+=" ${CT_EXTRA_FLAGS_FOR_HOST}" FWIW, I brought this issue up in February: http://sourceware.org/ml/crossgcc/2012-02/msg00089.html I should've sent a patch but it was so easy to just use CT_EXTRA_FLAGS_FOR_HOST... Johannes -- For unsubscribe information see http://sourceware.org/lists.html#faq
On 14 November 2012 22:40, Johannes Stezenbach <js@sig21.net> wrote: > On Wed, Nov 14, 2012 at 02:06:18PM +1300, Michael Hope wrote: >> On 14 November 2012 13:30, Yann E. MORIN <yann.morin.1998@free.fr> wrote: >> > On Wednesday 14 November 2012 Michael Hope wrote: >> >> It turns out that GCC and the libraries are being built without >> >> optimisation. > ... >> --- a/scripts/crosstool-NG.sh.in Fri Nov 09 18:22:31 2012 +0100 >> +++ b/scripts/crosstool-NG.sh.in Wed Nov 14 13:48:18 2012 +1300 >> @@ -494,7 +494,9 @@ >> fi >> >> # Help gcc >> - CT_CFLAGS_FOR_HOST= >> + # Explicitly optimise, else the lines below will overide the >> + # package's default optimisation flags >> + CT_CFLAGS_FOR_HOST="-O2 -g" >> [ "${CT_USE_PIPES}" = "y" ] && CT_CFLAGS_FOR_HOST+=" -pipe" >> CT_CFLAGS_FOR_HOST+=" ${CT_EXTRA_FLAGS_FOR_HOST}" > > FWIW, I brought this issue up in February: > http://sourceware.org/ml/crossgcc/2012-02/msg00089.html > > I should've sent a patch but it was so easy to just > use CT_EXTRA_FLAGS_FOR_HOST... Looking at the original discussion, a nice thing about putting these options first is EXTRA_FLAGS appear later in the command line and can override these defaults. So if you want to build at -Os you can. I can't find the 'disable debug' option though - I thought there was a '-no-flag-name' such as '-no-g' addeded in recent GCCs. -- Michael -- For unsubscribe information see http://sourceware.org/lists.html#faq
Michael, All, On Wednesday 14 November 2012 Michael Hope wrote: > scripts: set default CFLAGS to optimise. OK, will push. Thank you! :-) > On 14 November 2012 13:30, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > Also, I'd like to review your crosstool-NG fork, to see what we can bring > > back upstream, so you get less to maintain in your tree, so it makes it > > easier for you to follow upstream. That item's been basically sitting quite > > high on my TODO-list, but time being sparse, I always post-poned it. I'll > > try to get to it during this cycle. > > It's our fault for forking. Most of the stuff is Linaro specific > (samples, outer build scripts) and the remainder is hacks. Well, at least we can try to see if there are things that can be shaped for upstreaming. (And no, forking is not a fault!) > We're going to rebase as part of upstreaming the aarch64 support to > you. Ah-Ah! See, you've got things to upstream! :-) I'm eager to see that! > I was reluctant to post it as we needed to pick random binutils > and other versions, but the recent Microblaze work has added all we > need. Great! Looks like the timing was good, then. :-) Regards, Yann E. MORIN.
Johannes, All, On Wednesday 14 November 2012 Johannes Stezenbach wrote: > On Wed, Nov 14, 2012 at 02:06:18PM +1300, Michael Hope wrote: > > On 14 November 2012 13:30, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > On Wednesday 14 November 2012 Michael Hope wrote: > > >> It turns out that GCC and the libraries are being built without > > >> optimisation. [--SNIP--] > FWIW, I brought this issue up in February: > http://sourceware.org/ml/crossgcc/2012-02/msg00089.html Doh... Sorry, it slipped through the cracks... :-( Regards, Yann E. MORIN.
Michael, All,
Your patch:
scripts: set default CFLAGS to optimise.
has been applied as: #a9130ff13b19
http://crosstool-ng.org/hg/crosstool-ng/rev/a9130ff13b19
Thank you!
Regards,
Yann E. MORIN.
--
For unsubscribe information see http://sourceware.org/lists.html#faq
diff -r cfb1783d4cb8 -r d7c10d1bc152 scripts/crosstool-NG.sh.in --- a/scripts/crosstool-NG.sh.in Fri Nov 09 18:22:31 2012 +0100 +++ b/scripts/crosstool-NG.sh.in Wed Nov 14 13:48:18 2012 +1300 @@ -494,7 +494,9 @@ fi # Help gcc - CT_CFLAGS_FOR_HOST= + # Explicitly optimise, else the lines below will overide the + # package's default optimisation flags + CT_CFLAGS_FOR_HOST="-O2 -g" [ "${CT_USE_PIPES}" = "y" ] && CT_CFLAGS_FOR_HOST+=" -pipe" CT_CFLAGS_FOR_HOST+=" ${CT_EXTRA_FLAGS_FOR_HOST}"