From patchwork Tue Nov 13 13:37:02 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 198679 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A9C252C00B1 for ; Wed, 14 Nov 2012 00:40:48 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754758Ab2KMNhn (ORCPT ); Tue, 13 Nov 2012 08:37:43 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:61759 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754482Ab2KMNhl (ORCPT ); Tue, 13 Nov 2012 08:37:41 -0500 Received: by mail-pb0-f46.google.com with SMTP id rr4so5111363pbb.19 for ; Tue, 13 Nov 2012 05:37:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=vkMP9jfGJm2pqHo5siyhWsaoKreloGYnTT0gvthilZo=; b=hEs9uNbryE3bXyvgGvEplGxXniyFl5uhMXDA8eVrEk0171IyWjKHfKHR7+3XFDirpB TNkL37htp7SUnTtu05fTSRAFoh+BTXF4XGg8AZ0neIanQiHaxxwVlNfE3ALQyMWFFN3m g32fQn0gOXtOl/Fy1U+//PzdHgECDIU3bEVpWy5XJgd5pCWph8+vFeif9e0VVDxesZln X46Ks8v6wQN26ikYVPM12yecbFJtHrSrCGO3bXOrUEDxi0iQMBZxDpvcHWSGsw/FZeai rRQvRRS5Ku1VQE9F477h2wWIJIUHkq/Ugh9/aXzJgEDEuO8uJ0aJ4kT5SsXd3UUwlMHW jtIg== Received: by 10.66.86.165 with SMTP id q5mr58181733paz.18.1352813858935; Tue, 13 Nov 2012 05:37:38 -0800 (PST) Received: from localhost.localdomain (p1120-ipbf2201hodogaya.kanagawa.ocn.ne.jp. [123.220.186.120]) by mx.google.com with ESMTPS id vo8sm5988920pbc.16.2012.11.13.05.37.37 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 13 Nov 2012 05:37:38 -0800 (PST) From: Akinobu Mita To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: Akinobu Mita , Eilon Greenstein , netdev@vger.kernel.org Subject: [PATCH v3 03/11] bnx2x: use prandom_bytes() Date: Tue, 13 Nov 2012 22:37:02 +0900 Message-Id: <1352813830-4624-4-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1352813830-4624-1-git-send-email-akinobu.mita@gmail.com> References: <1352813830-4624-1-git-send-email-akinobu.mita@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use prandom_bytes() to fill rss key with pseudo-random bytes. Signed-off-by: Akinobu Mita Cc: Eilon Greenstein Cc: netdev@vger.kernel.org --- * v3 - rename random32_get_bytes to prandom_bytes drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index 4833b6a..257d38b 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c @@ -1741,7 +1741,6 @@ int bnx2x_config_rss_pf(struct bnx2x *bp, struct bnx2x_rss_config_obj *rss_obj, bool config_hash) { struct bnx2x_config_rss_params params = {NULL}; - int i; /* Although RSS is meaningless when there is a single HW queue we * still need it enabled in order to have HW Rx hash generated. @@ -1773,9 +1772,7 @@ int bnx2x_config_rss_pf(struct bnx2x *bp, struct bnx2x_rss_config_obj *rss_obj, if (config_hash) { /* RSS keys */ - for (i = 0; i < sizeof(params.rss_key) / 4; i++) - params.rss_key[i] = random32(); - + prandom_bytes(params.rss_key, sizeof(params.rss_key)); __set_bit(BNX2X_RSS_SET_SRCH, ¶ms.rss_flags); }