Patchwork nbd: fixes to read-only handling

login
register
mail settings
Submitter Paolo Bonzini
Date Nov. 13, 2012, 10:19 a.m.
Message ID <1352801961-9868-1-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/198597/
State New
Headers show

Comments

Paolo Bonzini - Nov. 13, 2012, 10:19 a.m.
We do not need BLKROSET if the kernel supports setting flags.
Also, always do BLKROSET even for a read-write export, otherwise
the read-only state remains "sticky" after the invocation of
"qemu-nbd -r".

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 nbd.c | 25 ++++++++++++-------------
 1 file modificato, 12 inserzioni(+), 13 rimozioni(-)

Patch

diff --git a/nbd.c b/nbd.c
index cec5a94..97a5914 100644
--- a/nbd.c
+++ b/nbd.c
@@ -596,24 +596,23 @@  int nbd_init(int fd, int csock, uint32_t flags, off_t size, size_t blocksize)
         return -serrno;
     }
 
-    if (flags & NBD_FLAG_READ_ONLY) {
-        int read_only = 1;
-        TRACE("Setting readonly attribute");
-
-        if (ioctl(fd, BLKROSET, (unsigned long) &read_only) < 0) {
+    if (ioctl(fd, NBD_SET_FLAGS, flags) < 0) {
+        if (errno == ENOTTY) {
+            int read_only = (flags & NBD_FLAG_READ_ONLY) != 0;
+            TRACE("Setting readonly attribute");
+
+            if (ioctl(fd, BLKROSET, (unsigned long) &read_only) < 0) {
+                int serrno = errno;
+                LOG("Failed setting read-only attribute");
+                return -serrno;
+            }
+        } else {
             int serrno = errno;
-            LOG("Failed setting read-only attribute");
+            LOG("Failed setting flags");
             return -serrno;
         }
     }
 
-    if (ioctl(fd, NBD_SET_FLAGS, flags) < 0
-        && errno != ENOTTY) {
-        int serrno = errno;
-        LOG("Failed setting flags");
-        return -serrno;
-    }
-
     TRACE("Negotiation ended");
 
     return 0;