Patchwork Include tm_p.h in asan.c

login
register
mail settings
Submitter Jakub Jelinek
Date Nov. 13, 2012, 7:39 a.m.
Message ID <20121113073905.GU1886@tucnak.redhat.com>
Download mbox | patch
Permalink /patch/198551/
State New
Headers show

Comments

Jakub Jelinek - Nov. 13, 2012, 7:39 a.m.
On Mon, Nov 12, 2012 at 10:13:08PM -0500, David Edelsohn wrote:
> gcc/asan.c probably should have been split into two files because it
> works at multiple levels.  But given that it invokes
> ASM_GENERATE_INTERNAL_LABEL, it needs to include tm_p.h to include
> <target>-protos.h.
> 
> Committed as obvious to allow AIX bootstrap to proceed.
> 
>         * asan.c: Include tm_p.h

Thanks, but Makefile.in needs to be adjusted accordingly too.  Committed
as obvious.

2012-11-13  Jakub Jelinek  <jakub@redhat.com>

	* Makefile.in (asan.o): Depend on $(TM_P_H).



	Jakub
David Edelsohn - Nov. 13, 2012, 2:05 p.m.
On Tue, Nov 13, 2012 at 2:39 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Mon, Nov 12, 2012 at 10:13:08PM -0500, David Edelsohn wrote:
>> gcc/asan.c probably should have been split into two files because it
>> works at multiple levels.  But given that it invokes
>> ASM_GENERATE_INTERNAL_LABEL, it needs to include tm_p.h to include
>> <target>-protos.h.
>>
>> Committed as obvious to allow AIX bootstrap to proceed.
>>
>>         * asan.c: Include tm_p.h
>
> Thanks, but Makefile.in needs to be adjusted accordingly too.  Committed

Thanks.

I am disappointed that this patch was not better tested and the
dependencies of other targets were not considered more thoroughly
before the merge.

- David

Patch

--- gcc/Makefile.in.jj	2012-11-12 16:58:42.000000000 +0100
+++ gcc/Makefile.in	2012-11-13 08:36:41.470663811 +0100
@@ -2211,7 +2211,7 @@  stor-layout.o : stor-layout.c $(CONFIG_H
 asan.o : asan.c asan.h $(CONFIG_H) $(SYSTEM_H) $(GIMPLE_H) \
    output.h coretypes.h $(GIMPLE_PRETTY_PRINT_H) \
    tree-iterator.h $(TREE_FLOW_H) $(TREE_PASS_H) \
-   $(TARGET_H) $(EXPR_H) $(OPTABS_H)
+   $(TARGET_H) $(EXPR_H) $(OPTABS_H) $(TM_P_H)
 tree-ssa-tail-merge.o: tree-ssa-tail-merge.c \
    $(SYSTEM_H) $(CONFIG_H) coretypes.h $(TM_H) $(BITMAP_H) \
    $(FLAGS_H) $(TM_P_H) $(BASIC_BLOCK_H) \