From patchwork Tue Nov 13 01:38:22 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 198518 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 31C092C0090 for ; Tue, 13 Nov 2012 12:38:42 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1353375523; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:Received:Date:Message-Id:From:To: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=PHvx353HYuwY5o7V85FP njP+qGE=; b=cbmYLvLiPKA3K47BRIx5Kbnok4CFpYVWzEz9VaPP1xTu6JYQUe4k TngLj62RR/EZh+Ew7XN0/+PiGIeYzj6G7rCsVvIYhLdxugkXzpOWuA3qxg9AZSy3 6K+5AE0hurZZoQkCl2MZ6KGVV2NDeDXS1LFVyo2N863QTh1htvY8yu0= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Received:Received:Date:Message-Id:From:To:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=H4+7uSpMXpu1pSP07YRw7c0tg6lOmnsoJwtxQPniNbWsgMBGx6w7GTefb7FMkt SSTHhKY0O15km3MHjI7zHuOlcXzD6iLaBvxfqvFgNvH9weTqM6NhJVFjB/vb3ej8 M8vX8+ssPo52Qj8uWAxWvirn45eMT7STv+lGc1qHuUWho=; Received: (qmail 6794 invoked by alias); 13 Nov 2012 01:38:34 -0000 Received: (qmail 6769 invoked by uid 22791); 13 Nov 2012 01:38:33 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_HOSTKARMA_NO, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from ra.se.axis.com (HELO ra.se.axis.com) (195.60.68.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Nov 2012 01:38:25 +0000 Received: from localhost (localhost [127.0.0.1]) by ra.se.axis.com (Postfix) with ESMTP id 9A3191594E for ; Tue, 13 Nov 2012 02:38:23 +0100 (CET) Received: from ra.se.axis.com ([127.0.0.1]) by localhost (ra.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1Zp+mOiFey1O for ; Tue, 13 Nov 2012 02:38:22 +0100 (CET) Received: from thoth.se.axis.com (thoth.se.axis.com [10.0.2.173]) by ra.se.axis.com (Postfix) with ESMTP id 998A413DE7 for ; Tue, 13 Nov 2012 02:38:22 +0100 (CET) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by thoth.se.axis.com (Postfix) with ESMTP id 8692D3419C; Tue, 13 Nov 2012 02:38:22 +0100 (CET) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id qAD1cM3q013970; Tue, 13 Nov 2012 02:38:22 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id qAD1cMWL013966; Tue, 13 Nov 2012 02:38:22 +0100 Date: Tue, 13 Nov 2012 02:38:22 +0100 Message-Id: <201211130138.qAD1cMWL013966@ignucius.se.axis.com> From: Hans-Peter Nilsson To: gcc-patches@gcc.gnu.org Subject: Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it. MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org While the fallout(*) from the libsanitizer commit is handled, it's obvious it should have a noconfigdirs= section in toplevel/configure.ac like the other target libs. Here's what I committed after observing that a cris-elf build passed, where it previously failed building libsanitizer which wrongly tries to compile using -fPIC despite checking in its configure.ac IIUC. But, I'd like to update the target contents there to something a bit more generic. Maybe disable libsanitizer everywhere except for (referring to the three common target-related file-name parts in libsanitizer) "mac", "win" and "linux"? Or disable everywhere except x86_64 / i386? That's the only port that defines the required TARGET_ASAN_SHADOW_OFFSET. Maybe the library configure.ac should check whether using -fsanitizer is error-free and disable the libsanitizer build automatically? toplevel: * configure.ac: Add section for noconfigdirs for libsanitizer. Disable for cris-*-* and mmix-*-*. * configure: Regenerate. *) -fPIC passed when building libsanitizer for targets that don't support it, lack of multilib setup for libsanitizer, libsanitizer not installed in version-specific subdir... Basically, IMHO it should just copy the generic libgfortran/configure.ac and be done with it. Right now it has the smallest configure.ac of the target-libraries. brgds, H-P Index: configure.ac =================================================================== --- configure.ac (revision 193455) +++ configure.ac (working copy) @@ -547,6 +547,13 @@ case "${target}" in ;; esac +# Disable libsanitizer for some systems. +case "${target}" in + cris-*-* | crisv32-*-* | mmix-*-*) + noconfigdirs="$noconfigdirs target-libsanitizer" + ;; +esac + # Disable libssp for some systems. case "${target}" in avr-*-*) Index: configure =================================================================== --- configure (revision 193455) +++ configure (working copy) @@ -3205,6 +3205,13 @@ case "${target}" in ;; esac +# Disable libsanitizer for some systems. +case "${target}" in + cris-*-* | crisv32-*-* | mmix-*-*) + noconfigdirs="$noconfigdirs target-libsanitizer" + ;; +esac + # Disable libssp for some systems. case "${target}" in avr-*-*)