From patchwork Mon Nov 12 21:38:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduardo Habkost X-Patchwork-Id: 198484 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A108C2C0090 for ; Tue, 13 Nov 2012 09:04:57 +1100 (EST) Received: from localhost ([::1]:55597 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TY1iZ-0006El-AL for incoming@patchwork.ozlabs.org; Mon, 12 Nov 2012 16:38:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TY1hg-0004Im-Vb for qemu-devel@nongnu.org; Mon, 12 Nov 2012 16:38:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TY1hd-0004gr-SQ for qemu-devel@nongnu.org; Mon, 12 Nov 2012 16:38:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TY1hd-0004fJ-Hy for qemu-devel@nongnu.org; Mon, 12 Nov 2012 16:37:57 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qACLbsH8030356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 12 Nov 2012 16:37:54 -0500 Received: from blackpad.lan.raisama.net (vpn1-5-14.gru2.redhat.com [10.97.5.14]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qACLbrlv024649; Mon, 12 Nov 2012 16:37:54 -0500 Received: by blackpad.lan.raisama.net (Postfix, from userid 500) id AB8B5203417; Mon, 12 Nov 2012 19:39:05 -0200 (BRST) From: Eduardo Habkost To: qemu-devel@nongnu.org, Igor Mammedov , =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Mon, 12 Nov 2012 19:38:51 -0200 Message-Id: <1352756342-13716-7-git-send-email-ehabkost@redhat.com> In-Reply-To: <1352756342-13716-1-git-send-email-ehabkost@redhat.com> References: <1352756342-13716-1-git-send-email-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Don Slutz Subject: [Qemu-devel] [PATCH 06/17] target-i386: cpu_x86_init(): print error message in case of error X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Error information is being ignored and never returned to the caller. While we don't change cpu_x86_init() to not return error information, print error message inside cpu_x86_init() in case of error. Signed-off-by: Eduardo Habkost --- Changes v2: - Use error_report() - Add "cpu_x86_init:" prefix to error message --- target-i386/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 69f1204..2907fb0 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1517,6 +1517,7 @@ X86CPU *cpu_x86_init(const char *cpu_model) error: object_delete(OBJECT(cpu)); if (error) { + error_report("cpu_x86_init: %s", error_get_pretty(error)); error_free(error); } return NULL;