Patchwork [2/4] bnx2x: Missing rmb when waiting for FW response

login
register
mail settings
Submitter Eilon Greenstein
Date Jan. 22, 2009, 4:01 p.m.
Message ID <1232640089.29087.52.camel@lb-tlvb-eliezer>
Download mbox | patch
Permalink /patch/19838/
State Accepted
Delegated to: David Miller
Headers show

Comments

Eilon Greenstein - Jan. 22, 2009, 4:01 p.m.
Waiting for the FW to response requires a memory barrier

Signed-off-by: Michal Kalderon <michals@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
 drivers/net/bnx2x_main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index 71fbf2d..f71b8a5 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -6622,6 +6622,7 @@  static int bnx2x_stop_leading(struct bnx2x *bp)
 		}
 		cnt--;
 		msleep(1);
+		rmb(); /* Refresh the dsb_sp_prod */
 	}
 	bp->state = BNX2X_STATE_CLOSING_WAIT4_UNLOAD;
 	bp->fp[0].state = BNX2X_FP_STATE_CLOSED;