From patchwork Sun Nov 11 21:33:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: ext4: init pagevec in ext4_da_block_invalidatepages Date: Sun, 11 Nov 2012 11:33:34 -0000 From: Eric Sandeen X-Patchwork-Id: 198298 Message-Id: <50A019AE.7090907@redhat.com> To: ext4 development Cc: stable@kernel.org ext4_da_block_invalidatepages is missing a pagevec_init(), which means that pvec->cold contains random garbage. This affects whether the page goes to the front or back of the LRU when ->cold makes it to free_hot_cold_page() Signed-off-by: Eric Sandeen --- -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index b3c243b..f89c0e5 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -1503,6 +1503,8 @@ static void ext4_da_block_invalidatepages(struct mpage_da_data *mpd) index = mpd->first_page; end = mpd->next_page - 1; + + pagevec_init(&pvec, 0); while (index <= end) { nr_pages = pagevec_lookup(&pvec, mapping, index, PAGEVEC_SIZE); if (nr_pages == 0)