Patchwork [01/23] dependencies.sh: remove makeinfo (texinfo) from the requirement list

login
register
mail settings
Submitter Samuel Martin
Date Nov. 11, 2012, 1:14 p.m.
Message ID <1352639701-27829-2-git-send-email-s.martin49@gmail.com>
Download mbox | patch
Permalink /patch/198260/
State Deferred
Headers show

Comments

Samuel Martin - Nov. 11, 2012, 1:14 p.m.
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Thomas Petazzoni - Nov. 11, 2012, 5:10 p.m.
Dear Samuel Martin,

On Sun, 11 Nov 2012 14:14:39 +0100, Samuel Martin wrote:
> 
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>

Why do you think they are no longer necessary? IIRC, they are needed
for the build of binutils/gcc during the internal backend toolchain
build. But I admittedly haven't tested building with these recently.

Best regards,

Thomas
Peter Korsgaard - Nov. 15, 2012, 11 p.m.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Dear Samuel Martin,
 Thomas> On Sun, 11 Nov 2012 14:14:39 +0100, Samuel Martin wrote:
 >> 
 >> Signed-off-by: Samuel Martin <s.martin49@gmail.com>

 Thomas> Why do you think they are no longer necessary? IIRC, they are
 Thomas> needed for the build of binutils/gcc during the internal
 Thomas> backend toolchain build. But I admittedly haven't tested
 Thomas> building with these recently.

Ok, I'll drop this patch for now as discussed on IRC.

Patch

diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
index 9f0f6a9..403ad75 100755
--- a/support/dependencies/dependencies.sh
+++ b/support/dependencies/dependencies.sh
@@ -131,12 +131,10 @@  if ! $SHELL --version 2>&1 | grep -q '^GNU bash'; then
 fi;
 
 # Check that a few mandatory programs are installed
-for prog in awk bison flex msgfmt makeinfo patch gzip bzip2 perl tar wget cpio python unzip rsync ${DL_TOOLS} ; do
+for prog in awk bison flex msgfmt patch gzip bzip2 perl tar wget cpio python unzip rsync ${DL_TOOLS} ; do
     if ! which $prog > /dev/null ; then
 	/bin/echo -e "\nYou must install '$prog' on your build machine";
-	if test $prog = "makeinfo" ; then
-	    /bin/echo -e "makeinfo is usually part of the texinfo package in your distribution\n"
-	elif test $prog = "msgfmt" ; then
+	if test $prog = "msgfmt" ; then
 	    /bin/echo -e "msgfmt is usually part of the gettext package in your distribution\n"
 	elif test $prog = "svn" ; then
 	    /bin/echo -e "svn is usually part of the subversion package in your distribution\n"