Patchwork tremor: force ARM mode when building to avoid Thumb2 build problems

login
register
mail settings
Submitter Thomas Petazzoni
Date Nov. 10, 2012, 10:43 p.m.
Message ID <1352587381-9864-1-git-send-email-thomas.petazzoni@free-electrons.com>
Download mbox | patch
Permalink /patch/198227/
State Accepted
Commit 695c4bcebc6093f44d21117489bb72cc7c76c5af
Headers show

Comments

Thomas Petazzoni - Nov. 10, 2012, 10:43 p.m.
Fixes:

  http://autobuild.buildroot.org/results/502b7d3f29d7982d56de2ae4a0b943315e04713b/build-end.log

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/tremor/tremor.mk |    7 +++++++
 1 file changed, 7 insertions(+)
Thomas Petazzoni - Nov. 15, 2012, 3:16 p.m.
On Sat, 10 Nov 2012 23:43:01 +0100, Thomas Petazzoni wrote:
> Fixes:
> 
>   http://autobuild.buildroot.org/results/502b7d3f29d7982d56de2ae4a0b943315e04713b/build-end.log
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/tremor/tremor.mk |    7 +++++++
>  1 file changed, 7 insertions(+)

This one should be applied for 2012.11.

Best regards,

Thomas
Peter Korsgaard - Nov. 15, 2012, 3:41 p.m.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Fixes:
 Thomas>   http://autobuild.buildroot.org/results/502b7d3f29d7982d56de2ae4a0b943315e04713b/build-end.log

Committed, thanks.

Patch

diff --git a/package/tremor/tremor.mk b/package/tremor/tremor.mk
index fceee1b..cd1d323 100644
--- a/package/tremor/tremor.mk
+++ b/package/tremor/tremor.mk
@@ -12,4 +12,11 @@  TREMOR_AUTORECONF = YES
 TREMOR_INSTALL_STAGING = YES
 TREMOR_DEPENDENCIES = libogg
 
+# tremor has ARM assembly code that cannot be compiled in Thumb2 mode,
+# so we must force the traditional ARM mode.
+ifeq ($(BR2_arm),y)
+TREMOR_CONF_ENV = \
+	CFLAGS="$(TARGET_CFLAGS) -marm"
+endif
+
 $(eval $(autotools-package))