Patchwork [Committed] Add testcase

login
register
mail settings
Submitter Andrew Pinski
Date Nov. 10, 2012, 3:22 a.m.
Message ID <CA+=Sn1mNokHcLszXj5jCGEDAeCjWE7eWCiN3USYK8nNMeaz3XQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/198169/
State New
Headers show

Comments

Andrew Pinski - Nov. 10, 2012, 3:22 a.m.
Hi,
  While I was working on using zero_extract more on the left hand side
in combine, I found a bug in my code but there was no testcase in the
testsuite that tested it.  The code originally comes from uboot which
was failing when doing a ping or tftp.

Committed the testcase as obvious after a quick test to make sure it
works.  Note someone might need to mark the testcase as only
executable on targets which have 32bit ints.

Thanks,
Andrew Pinski

ChangeLog:
 * gcc.c-torture/execute/20121108-1.c: New testcase.
Hans-Peter Nilsson - Nov. 15, 2012, 8:48 p.m.
On Fri, 9 Nov 2012, Andrew Pinski wrote:
> Committed the testcase as obvious after a quick test to make sure it
> works.  Note someone might need to mark the testcase as only
> executable on targets which have 32bit ints.

Someone like you?  There are plenty of greppable
effective-target attributes and gcc.c-torture handles dg-
marking fine these days.

> ChangeLog:
>  * gcc.c-torture/execute/20121108-1.c: New testcase.

Please avoid printing things, just call abort or exit.

brgds, H-P

Patch

Index: gcc.c-torture/execute/20121108-1.c
===================================================================
--- gcc.c-torture/execute/20121108-1.c	(revision 0)
+++ gcc.c-torture/execute/20121108-1.c	(revision 0)
@@ -0,0 +1,51 @@ 
+char temp[] = "192.168.190.160";
+unsigned result = (((((192u<<8)|168u)<<8)|190u)<<8)|160u;
+
+int strtoul1(const char *a, char **b, int c) __attribute__((noinline, noclone));
+int strtoul1(const char *a, char **b, int c)
+{
+  *b = a+3;
+  if (a == temp)
+    return 192;
+  else if (a == temp+4)
+    return 168;
+  else if (a == temp+8)
+    return 190;
+  else if (a == temp+12)
+    return 160;
+  __builtin_abort();
+}
+
+int string_to_ip(const char *s) __attribute__((noinline,noclone));
+int string_to_ip(const char *s)
+{
+        int addr;
+        char *e;
+        int i;
+
+        if (s == 0)
+                return(0);
+
+        for (addr=0, i=0; i<4; ++i) {
+                int val = s ? strtoul1(s, &e, 10) : 0;
+                addr <<= 8;
+                addr |= (val & 0xFF);
+                if (s) {
+                        s = (*e) ? e+1 : e;
+                }
+        }
+
+        return addr;
+}
+
+int main(void)
+{
+  int t = string_to_ip (temp);
+  printf ("%x\n", t);
+  printf ("%x\n", result);
+  if (t != result)
+    __builtin_abort ();
+  printf ("WORKS.\n");
+  return 0;
+}
+