Patchwork [15/24] qlist.h: do not include qemu-common.h

login
register
mail settings
Submitter Eduardo Habkost
Date Nov. 9, 2012, 2:56 p.m.
Message ID <1352473012-20500-16-git-send-email-ehabkost@redhat.com>
Download mbox | patch
Permalink /patch/198111/
State New
Headers show

Comments

Eduardo Habkost - Nov. 9, 2012, 2:56 p.m.
I don't know why it was including it, as I don't see any code that
depends on anything from qemu-common.h.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 qlist.h | 1 -
 1 file changed, 1 deletion(-)
Andreas Färber - Nov. 14, 2012, 10:42 p.m.
Am 09.11.2012 15:56, schrieb Eduardo Habkost:
> I don't know why it was including it, as I don't see any code that
> depends on anything from qemu-common.h.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  qlist.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/qlist.h b/qlist.h
> index ae776f9..7408947 100644
> --- a/qlist.h
> +++ b/qlist.h
> @@ -15,7 +15,6 @@
>  
>  #include "qobject.h"
>  #include "qemu-queue.h"
> -#include "qemu-common.h"
>  #include "qemu-queue.h"
>  
>  typedef struct QListEntry {

  CC    qga/channel-posix.o
/home/andreas/QEMU/qemu-rcar/qga/channel-posix.c: In function
‘ga_channel_open’:
/home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:141:13: error: implicit
declaration of function ‘exit’ [-Werror=implicit-function-declaration]
/home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:141:13: error:
incompatible implicit declaration of built-in function ‘exit’ [-Werror]
/home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:141:18: error:
‘EXIT_FAILURE’ undeclared (first use in this function)
/home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:141:18: note: each
undeclared identifier is reported only once for each function it appears in
/home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:163:13: error:
incompatible implicit declaration of built-in function ‘exit’ [-Werror]
cc1: all warnings being treated as errors
make: *** [qga/channel-posix.o] Fehler 1

Sounds related to not doing qemu-stdio.h...

Andreas

Patch

diff --git a/qlist.h b/qlist.h
index ae776f9..7408947 100644
--- a/qlist.h
+++ b/qlist.h
@@ -15,7 +15,6 @@ 
 
 #include "qobject.h"
 #include "qemu-queue.h"
-#include "qemu-common.h"
 #include "qemu-queue.h"
 
 typedef struct QListEntry {