From patchwork Mon Sep 29 21:51:09 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arthur Jones X-Patchwork-Id: 1981 X-Patchwork-Delegate: jgarzik@pobox.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 2498BDDDEC for ; Tue, 30 Sep 2008 07:51:25 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751772AbYI2VvM (ORCPT ); Mon, 29 Sep 2008 17:51:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751897AbYI2VvL (ORCPT ); Mon, 29 Sep 2008 17:51:11 -0400 Received: from smtp1.riverbed.com ([206.169.144.12]:2549 "EHLO smtp1.riverbed.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbYI2VvL (ORCPT ); Mon, 29 Sep 2008 17:51:11 -0400 Received: from unknown (HELO exhub2.nbttech.com) ([10.16.4.1]) by smtp1.riverbed.com with ESMTP; 29 Sep 2008 14:51:10 -0700 Received: from localhost (10.32.69.20) by exhub2.nbttech.com (10.16.0.165) with Microsoft SMTP Server (TLS) id 8.1.263.0; Mon, 29 Sep 2008 14:51:09 -0700 Date: Mon, 29 Sep 2008 14:51:09 -0700 From: Arthur Jones To: e1000-devel@lists.sourceforge.net CC: netdev@vger.kernel.org Subject: [PATCH] e1000e: release hw semaphore after successfully writing EEPROM Message-ID: <20080929215109.GA23380@ajones-laptop.nbttech.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Since e1000e has been existance in linux-2.6, we've never released the hardware semaphore after a successful write to the SPI EEPROM. I guess we don't write to SPI EEPROM much -- but those few of us that do appreciate it when we can later read from the EEPROM without having to reboot. Found-by: Nick Van Fossen Signed-off-by: Arthur Jones Reviewed-by: Auke Kok --- drivers/net/e1000e/lib.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/e1000e/lib.c b/drivers/net/e1000e/lib.c index f1f4e9d..6492107 100644 --- a/drivers/net/e1000e/lib.c +++ b/drivers/net/e1000e/lib.c @@ -2012,6 +2012,7 @@ s32 e1000e_write_nvm_spi(struct e1000_hw *hw, u16 offset, u16 words, u16 *data) } msleep(10); + nvm->ops.release_nvm(hw); return 0; }