Patchwork [1/2,v2] neard: new package

login
register
mail settings
Submitter Simon Dawson
Date Nov. 9, 2012, 1:51 p.m.
Message ID <1352469107-25993-1-git-send-email-spdawson@gmail.com>
Download mbox | patch
Permalink /patch/198068/
State Superseded
Headers show

Comments

Simon Dawson - Nov. 9, 2012, 1:51 p.m.
From: Simon Dawson <spdawson@gmail.com>

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
 v2: Incorporated improvements suggested by Thomas Petazzoni

 package/Config.in       |    1 +
 package/neard/Config.in |   12 ++++++++++++
 package/neard/neard.mk  |   15 +++++++++++++++
 3 files changed, 28 insertions(+)
 create mode 100644 package/neard/Config.in
 create mode 100644 package/neard/neard.mk
Arnout Vandecappelle - Nov. 10, 2012, 2:12 a.m.
On 11/09/12 14:51, spdawson@gmail.com wrote:
> Signed-off-by: Simon Dawson<spdawson@gmail.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
  (built-test on a minimal powerpc config)

  Regards,
  Arnout
Baruch Siach - Nov. 11, 2012, 5:11 a.m.
Hi Simon,

On Fri, Nov 09, 2012 at 01:51:47PM +0000, spdawson@gmail.com wrote:
> From: Simon Dawson <spdawson@gmail.com>
> 
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---

[...]

> --- /dev/null
> +++ b/package/neard/neard.mk
> @@ -0,0 +1,15 @@
> +#############################################################
> +#
> +# neard
> +#
> +#############################################################
> +NEARD_VERSION = 0.7

Version 0.8 seems to be available. Any reason not to use that one?

> +NEARD_SITE = $(BR2_KERNEL_MIRROR)/linux/network/nfc
> +NEARD_INSTALL_STAGING = YES

Why is this needed? Does this package export headers needed by others?

> +NEARD_LICENSE = GPLv2
> +NEARD_LICENSE_FILES = COPYING
> +
> +NEARD_DEPENDENCIES = dbus libglib2 libnl
> +NEARD_CONF_OPT = --disable-traces
> +
> +$(eval $(autotools-package))

baruch
Simon Dawson - Nov. 11, 2012, 10:04 a.m.
Hi Baruch; thanks for the feedback.

On 11 November 2012 05:11, Baruch Siach <baruch@tkos.co.il> wrote:
>> +NEARD_VERSION = 0.7
>
> Version 0.8 seems to be available. Any reason not to use that one?

No reason --- I just hadn't spotted that 0.8 had been released.

>> +NEARD_INSTALL_STAGING = YES
>
> Why is this needed? Does this package export headers needed by others?

In fact, this is not needed. I had thought that the neardal package
depended on headers installed by neard, but this is not the case.

I'll rework the neard and neardal patches, and resubmit.

Simon.

Patch

diff --git a/package/Config.in b/package/Config.in
index 074e9df..6115fb4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -237,6 +237,7 @@  source "package/mdadm/Config.in"
 source "package/memtester/Config.in"
 source "package/minicom/Config.in"
 source "package/nanocom/Config.in"
+source "package/neard/Config.in"
 source "package/ofono/Config.in"
 source "package/open2300/Config.in"
 source "package/openocd/Config.in"
diff --git a/package/neard/Config.in b/package/neard/Config.in
new file mode 100644
index 0000000..a50dbeb
--- /dev/null
+++ b/package/neard/Config.in
@@ -0,0 +1,12 @@ 
+config BR2_PACKAGE_NEARD
+	bool "neard"
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBNL
+	help
+	  Near Field Communication (NFC) manager. This userspace daemon is a part
+	  of the NFC stack provided by the Linux NFC project.
+
+	  http://git.kernel.org/?p=network/nfc/neard.git;a=summary
+
+	  https://01.org/linux-nfc/documentation/how-start-linux-nfc-code...
diff --git a/package/neard/neard.mk b/package/neard/neard.mk
new file mode 100644
index 0000000..8c12627
--- /dev/null
+++ b/package/neard/neard.mk
@@ -0,0 +1,15 @@ 
+#############################################################
+#
+# neard
+#
+#############################################################
+NEARD_VERSION = 0.7
+NEARD_SITE = $(BR2_KERNEL_MIRROR)/linux/network/nfc
+NEARD_INSTALL_STAGING = YES
+NEARD_LICENSE = GPLv2
+NEARD_LICENSE_FILES = COPYING
+
+NEARD_DEPENDENCIES = dbus libglib2 libnl
+NEARD_CONF_OPT = --disable-traces
+
+$(eval $(autotools-package))