Patchwork [1/2] neard: new package

login
register
mail settings
Submitter Simon Dawson
Date Nov. 9, 2012, 11:05 a.m.
Message ID <1352459105-13590-2-git-send-email-spdawson@gmail.com>
Download mbox | patch
Permalink /patch/198021/
State Superseded
Headers show

Comments

Simon Dawson - Nov. 9, 2012, 11:05 a.m.
From: Simon Dawson <spdawson@gmail.com>

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
 package/Config.in       |    1 +
 package/neard/Config.in |   15 +++++++++++++++
 package/neard/neard.mk  |   16 ++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/neard/Config.in
 create mode 100644 package/neard/neard.mk
Thomas Petazzoni - Nov. 9, 2012, 1:20 p.m.
On Fri,  9 Nov 2012 11:05:04 +0000, spdawson@gmail.com wrote:

> diff --git a/package/neard/Config.in b/package/neard/Config.in
> new file mode 100644
> index 0000000..f973fdd
> --- /dev/null
> +++ b/package/neard/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_NEARD
> +	bool "neard"
> +	depends on BR2_LINUX_KERNEL

Why this dependency?

> +	select BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_PACKAGE_LIBNL
> +	help
> +	  Near Field Communication (NFC) manager

A slightly longer description would be useful here.

> +
> +	  http://git.kernel.org/?p=network/nfc/neard.git;a=summary
> +
> +	  https://01.org/linux-nfc/documentation/how-start-linux-nfc-code...

Those "..." at the end look strange.

> diff --git a/package/neard/neard.mk b/package/neard/neard.mk
> new file mode 100644
> index 0000000..3d73932
> --- /dev/null
> +++ b/package/neard/neard.mk
> @@ -0,0 +1,16 @@
> +#############################################################
> +#
> +# neard
> +#
> +#############################################################
> +NEARD_VERSION = 0.7
> +NEARD_SITE = $(BR2_KERNEL_MIRROR)/linux/network/nfc
> +NEARD_INSTALL_STAGING = YES
> +NEARD_LICENSE = GPLv2
> +NEARD_LICENSE_FILES = COPYING
> +
> +NEARD_DEPENDENCIES = linux dbus libglib2 libnl
> +NEARD_AUTORECONF = YES

The package does not have any patches, and is downloaded from a
tarball. Why is an autoreconf needed?

Thanks,

Thomas
Simon Dawson - Nov. 9, 2012, 1:36 p.m.
Hi Thomas; thanks for the feedback.

On 9 November 2012 13:20, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
>
> > +     depends on BR2_LINUX_KERNEL
>
> Why this dependency?

You're right; this is superfluous.

> > +     help
> > +       Near Field Communication (NFC) manager
>
> A slightly longer description would be useful here.

Okay.

> > +       https://01.org/linux-nfc/documentation/how-start-linux-nfc-code...
>
> Those "..." at the end look strange.

Yes, they do look strange; but this is correct --- the dots are a
required part of the URL.

> > +NEARD_AUTORECONF = YES
>
> The package does not have any patches, and is downloaded from a
> tarball. Why is an autoreconf needed?

The autoreconf is not needed; thanks for pointing this out.

I'll rework the patch.

Simon.

Patch

diff --git a/package/Config.in b/package/Config.in
index 2ab6b6e..ffc08ab 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -236,6 +236,7 @@  source "package/mdadm/Config.in"
 source "package/memtester/Config.in"
 source "package/minicom/Config.in"
 source "package/nanocom/Config.in"
+source "package/neard/Config.in"
 source "package/ofono/Config.in"
 source "package/open2300/Config.in"
 source "package/openocd/Config.in"
diff --git a/package/neard/Config.in b/package/neard/Config.in
new file mode 100644
index 0000000..f973fdd
--- /dev/null
+++ b/package/neard/Config.in
@@ -0,0 +1,15 @@ 
+config BR2_PACKAGE_NEARD
+	bool "neard"
+	depends on BR2_LINUX_KERNEL
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBNL
+	help
+	  Near Field Communication (NFC) manager
+
+	  http://git.kernel.org/?p=network/nfc/neard.git;a=summary
+
+	  https://01.org/linux-nfc/documentation/how-start-linux-nfc-code...
+
+comment "neard requires a Linux kernel"
+	depends on !BR2_LINUX_KERNEL
diff --git a/package/neard/neard.mk b/package/neard/neard.mk
new file mode 100644
index 0000000..3d73932
--- /dev/null
+++ b/package/neard/neard.mk
@@ -0,0 +1,16 @@ 
+#############################################################
+#
+# neard
+#
+#############################################################
+NEARD_VERSION = 0.7
+NEARD_SITE = $(BR2_KERNEL_MIRROR)/linux/network/nfc
+NEARD_INSTALL_STAGING = YES
+NEARD_LICENSE = GPLv2
+NEARD_LICENSE_FILES = COPYING
+
+NEARD_DEPENDENCIES = linux dbus libglib2 libnl
+NEARD_AUTORECONF = YES
+NEARD_CONF_OPT = --disable-traces
+
+$(eval $(autotools-package))