From patchwork Fri Nov 9 09:42:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Botcazou X-Patchwork-Id: 198009 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 493822C0269 for ; Fri, 9 Nov 2012 20:45:54 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1353059155; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:From:To:Subject:Date:Message-ID:User-Agent:MIME-Version: Content-Type:Content-Transfer-Encoding:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=irasZusFP3v3rbKMbKRPr7TW5bQ=; b=hhVJh5c+/gNLUCo JQA/eBiWjl1P0nzVU8C6JCVjqKzRWcswOyAIphktxjHZveeQMU9vtglSqyFsn6DY IWgrwOlmVN6vPOsggLhKdYZFnDDwtHVrCr2vTAa/pdsRam5Vw/UnxHcbcQbPAtOg tcE1p0IWXhKtKzKrsxJOIKKfn0NE= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:From:To:Subject:Date:Message-ID:User-Agent:MIME-Version:Content-Type:Content-Transfer-Encoding:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=pint1qUa5+/i8ye5ECvOyt4vxdkLpOe9Mv0QBJnKArf+ltAAawOc+IgTQOFz8o b/ArztYtmgKhHGvgfPbN+mnbL24/ntutwh06ylPvNuQ11DSDbiOvFk2X786VeZOf b+AOqTaC6HplZaieJsJKPKdF69dJhGZsyyknZzlubmosc=; Received: (qmail 21901 invoked by alias); 9 Nov 2012 09:45:49 -0000 Received: (qmail 21892 invoked by uid 22791); 9 Nov 2012 09:45:48 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Nov 2012 09:45:44 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id E8511CB099F for ; Fri, 9 Nov 2012 10:45:44 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QTR6HmTaI9nA for ; Fri, 9 Nov 2012 10:45:44 +0100 (CET) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id B00ABCB08A3 for ; Fri, 9 Nov 2012 10:45:44 +0100 (CET) From: Eric Botcazou To: gcc-patches@gcc.gnu.org Subject: [Darwin] Do not enable -fvar-tracking at -O0 Date: Fri, 09 Nov 2012 10:42:45 +0100 Message-ID: <1912003.UO0AZ3kYWj@polaris> User-Agent: KMail/4.7.2 (Linux/3.1.10-1.16-desktop; KDE/4.7.2; x86_64; ; ) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, this is a regression present on the mainline and 4.7 branch. -fvar-tracking is automatically enabled on Darwin when -g is passed, including at -O0. This results in bloated and incomplete debug info. This comes from a latent issue in the handling of flag_var_tracking_uninit in the Darwin back-end, which wasn't updated for the new option machinery. Tested on x86_64-apple-darwin10.8.0, OK for mainline and 4.7 branch? 2012-11-09 Eric Botcazou * common.opt (fvar-tracking-uninit): Document. * toplev.c (process_options): Fix handling of flag_var_tracking_uninit. * config/darwin.c (darwin_override_options): Likewise. Index: toplev.c =================================================================== --- toplev.c (revision 193322) +++ toplev.c (working copy) @@ -1416,12 +1416,15 @@ process_options (void) /* If the user specifically requested variable tracking with tagging uninitialized variables, we need to turn on variable tracking. (We already determined above that variable tracking is feasible.) */ - if (flag_var_tracking_uninit) + if (flag_var_tracking_uninit == 1) flag_var_tracking = 1; if (flag_var_tracking == AUTODETECT_VALUE) flag_var_tracking = optimize >= 1; + if (flag_var_tracking_uninit == AUTODETECT_VALUE) + flag_var_tracking_uninit = flag_var_tracking; + if (flag_var_tracking_assignments == AUTODETECT_VALUE) flag_var_tracking_assignments = flag_var_tracking && !(flag_selective_scheduling || flag_selective_scheduling2); Index: common.opt =================================================================== --- common.opt (revision 193322) +++ common.opt (working copy) @@ -2189,6 +2189,10 @@ fvar-tracking-assignments-toggle Common Report Var(flag_var_tracking_assignments_toggle) Optimization Toggle -fvar-tracking-assignments +; Positive if we should track uninitialized variables, negative if +; we should run the var-tracking pass only to discard debug +; annotations. When flag_var_tracking_uninit == AUTODETECT_VALUE it +; will be set according to flag_var_tracking. fvar-tracking-uninit Common Report Var(flag_var_tracking_uninit) Optimization Perform variable tracking and also tag variables that are uninitialized Index: config/darwin.c =================================================================== --- config/darwin.c (revision 193322) +++ config/darwin.c (working copy) @@ -3038,12 +3038,12 @@ darwin_override_options (void) darwin_emit_branch_islands = true; } - if (flag_var_tracking + if (flag_var_tracking_uninit == 0 && generating_for_darwin_version >= 9 && (flag_gtoggle ? (debug_info_level == DINFO_LEVEL_NONE) : (debug_info_level >= DINFO_LEVEL_NORMAL)) && write_symbols == DWARF2_DEBUG) - flag_var_tracking_uninit = 1; + flag_var_tracking_uninit = flag_var_tracking; if (MACHO_DYNAMIC_NO_PIC_P) {