From patchwork Thu Nov 8 04:01:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Crosthwaite X-Patchwork-Id: 197751 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7FA942C0109 for ; Thu, 8 Nov 2012 15:01:35 +1100 (EST) Received: from localhost ([::1]:58875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWJJ7-0004vA-IO for incoming@patchwork.ozlabs.org; Wed, 07 Nov 2012 23:01:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWJJ1-0004uv-6v for qemu-devel@nongnu.org; Wed, 07 Nov 2012 23:01:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TWJIx-0002UV-VN for qemu-devel@nongnu.org; Wed, 07 Nov 2012 23:01:27 -0500 Received: from mail-pb0-f45.google.com ([209.85.160.45]:36826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWJIx-0002U4-PW for qemu-devel@nongnu.org; Wed, 07 Nov 2012 23:01:23 -0500 Received: by mail-pb0-f45.google.com with SMTP id rp2so1679571pbb.4 for ; Wed, 07 Nov 2012 20:01:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=LlTVfsnIpxVl7pyJqyH6L51hUdEwbOYaLmm7ywi4Q3c=; b=HMjuHczD9f5e5je4jegjpBSviWIxqiOkSrZ2sonMihaZyJ7xxWJkQkDjXsvVw6dhYJ fDa8gXYhOdJlu4ZtsA3xwZtl9k46eslBv9hNqHgGVnLmGGT7c+kRUh1gYCAQUHHdIaB3 1CkvEu9M/LyAEkjdS9zVW4SXkqkSxUdIrm1agfeh1pATonMj3cMMJd4NzaYKN94uFD3X x8BLkFHd3djnKFIOkebXxlEdncITSo4d2pNmysqTWP95cNWfESAzIlwkErLds3feE7Df XzVacldj+/AP9W+QBf8msK8Vv1eFNcsXJb2349UQAhcJdo4Ti/jfB9gtjIdSM070taGy Rblw== Received: by 10.68.253.4 with SMTP id zw4mr20112466pbc.143.1352347282547; Wed, 07 Nov 2012 20:01:22 -0800 (PST) Received: from localhost ([124.148.20.9]) by mx.google.com with ESMTPS id ve6sm15194669pbc.58.2012.11.07.20.01.19 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 07 Nov 2012 20:01:21 -0800 (PST) From: Peter Crosthwaite To: qemu-devel@nongnu.org, edgar.iglesias@gmail.com Date: Thu, 8 Nov 2012 14:01:19 +1000 Message-Id: <1352347279-769-1-git-send-email-peter.crosthwaite@xilinx.com> X-Mailer: git-send-email 1.7.0.4 X-Gm-Message-State: ALoCoQmI5cJdO4Dzr+MdI6tWUPanmMtQH6hNH9hpdlNNycrhYvvO+372jMrfLTQJsYIDePQA1TB8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.160.45 Cc: Peter Crosthwaite , git@xilinx.com Subject: [Qemu-devel] [QEMU PATCH] microblaze: translate.c: Fix swaph decoding X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The swaph instruction was not decoding correctly. s/1e1/1e2 on the 9 LSBs on the instruction decode. Reported-by: David Holsgrove Signed-off-by: Peter Crosthwaite --- target-microblaze/translate.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c index 7d864b1..6f27c24 100644 --- a/target-microblaze/translate.c +++ b/target-microblaze/translate.c @@ -840,7 +840,7 @@ static void dec_bit(DisasContext *dc) LOG_DIS("swapb r%d r%d\n", dc->rd, dc->ra); tcg_gen_bswap32_i32(cpu_R[dc->rd], cpu_R[dc->ra]); break; - case 0x1e1: + case 0x1e2: /*swaph */ LOG_DIS("swaph r%d r%d\n", dc->rd, dc->ra); tcg_gen_rotri_i32(cpu_R[dc->rd], cpu_R[dc->ra], 16);