From patchwork Thu Nov 8 01:37:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 197747 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 26B3D2C0100 for ; Thu, 8 Nov 2012 12:37:32 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1352943453; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:In-Reply-To:References:Date: Message-ID:Subject:From:To:Cc:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=btODXQzXQ4SFdiLUvp+3LaqQJik=; b=Kq3L4rbfgsgB06jgXgWN3sc8zg12OFDVLUReJ80ld4M8Aut+yiFDR+jAHTN0aj v8G6UbfzDHFWyhEh/0/vW/3xxI7R9T1AWxehYGrsI2hf7q23ZkZmBfmvUWKsYbJU CpCniUdsbYGkJZlhmThhhSxD6/UB8BGkODC3oD/154OXA= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:MIME-Version:Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Cc:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=kYWPWva9jHq6J+UMAaSAyv/5iGGZ8j3j3fJGG+LAJ1akP5YPRGkrjW2cionA9R yhYCvZDJ2apu/Gy/2N+GzgCRVd2hs8cyvm9TB0/pE+FU/PNiFpDdAttpKSGljhUd Bxy6r+pllXXr1tDMTXTch1r8aa0Nhg+2Hcf8vqA6OqSFI=; Received: (qmail 21808 invoked by alias); 8 Nov 2012 01:37:24 -0000 Received: (qmail 21792 invoked by uid 22791); 8 Nov 2012 01:37:23 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-ie0-f175.google.com (HELO mail-ie0-f175.google.com) (209.85.223.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Nov 2012 01:37:17 +0000 Received: by mail-ie0-f175.google.com with SMTP id c13so3632733ieb.20 for ; Wed, 07 Nov 2012 17:37:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.50.12.138 with SMTP id y10mr18236943igb.58.1352338637427; Wed, 07 Nov 2012 17:37:17 -0800 (PST) Received: by 10.42.158.202 with HTTP; Wed, 7 Nov 2012 17:37:17 -0800 (PST) In-Reply-To: References: <50995544.6020707@oracle.com> <509A3716.20909@oracle.com> Date: Thu, 8 Nov 2012 01:37:17 +0000 Message-ID: Subject: Re: [v3] Fix profile mode failures From: Jonathan Wakely To: Paolo Carlini Cc: "libstdc++" , gcc-patches Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 7 November 2012 10:55, Jonathan Wakely wrote: > On 7 November 2012 10:25, Paolo Carlini wrote: >> >> I'm for example seeing in the log: >> >> 23_containers/list/init-list.cc execution test >> >> pretty mysterious, > > Yes, I had a quick look at it but couldn't see the problem, so wanted > to fix the trivial vector problem first. > >> I think it's the first time I ever see it. > > Huh, then I guess I broke that one too. I won't rest until it's fixed ;-) Bah, it's nothing to do with me, the profile-mode list should never have worked! I'm testing this overnight. commit 756c968f9d35778e0b1c068c76833cbe8358a9d4 Author: Jonathan Wakely Date: Thu Nov 8 01:27:24 2012 +0000 * include/profile/iterator_tracker.h (operator++): Fix returning dangling reference. (operator--): Likewise. diff --git a/libstdc++-v3/include/profile/iterator_tracker.h b/libstdc++-v3/include/profile/iterator_tracker.h index 733429d..91f733c 100644 --- a/libstdc++-v3/include/profile/iterator_tracker.h +++ b/libstdc++-v3/include/profile/iterator_tracker.h @@ -93,7 +93,7 @@ namespace __profile return *this; } - __iterator_tracker& + __iterator_tracker operator++(int) { _M_ds->_M_profile_iterate(); @@ -110,7 +110,7 @@ namespace __profile return *this; } - __iterator_tracker& + __iterator_tracker operator--(int) { _M_ds->_M_profile_iterate(1);