Patchwork patch fixing a test for PR55151

login
register
mail settings
Submitter Vladimir Makarov
Date Nov. 7, 2012, 10:45 p.m.
Message ID <509AE474.4000103@redhat.com>
Download mbox | patch
Permalink /patch/197736/
State New
Headers show

Comments

Vladimir Makarov - Nov. 7, 2012, 10:45 p.m.
On 12-11-07 5:27 PM, H.J. Lu wrote:
> On Wed, Nov 7, 2012 at 2:21 PM, Vladimir Makarov <vmakarov@redhat.com> wrote:
>>    The following patch adds omitted target for the test.  The test was
>> supposed to run on x86-64 only.  On 32-bit x86, it should fail.  Reload
>> fails on this test on x86 too although with an error message.  I am going to
>> add a generation of a message too.
>>
>>    Committed as rev. 193311.
>>
>> 2012-11-07  Vladimir Makarov  <vmakarov@redhat.com>
>>
>>          PR rtl-optimization/55151
>>          * gcc.dg/pr55151.c: Compile it only for x86_64.
>>
> Checking x86_64-*-* target is incorrect since i686 GCC can support
> 64-bit.  You should check !ia32 target:
>
> /* { dg-do compile { target { ! { ia32 } } } } */
>
>
Thanks, H.J.  I've just fixed it.
Hans-Peter Nilsson - Nov. 8, 2012, 4:59 p.m.
On Wed, 7 Nov 2012, Vladimir Makarov wrote:
> On 12-11-07 5:27 PM, H.J. Lu wrote:
> > You should check !ia32 target:
> >
> > /* { dg-do compile { target { ! { ia32 } } } } */
> >
> >
> Thanks, H.J.  I've just fixed it.
>
> Index: testsuite/ChangeLog
> ===================================================================
> --- testsuite/ChangeLog (revision 193316)
> +++ testsuite/ChangeLog (working copy)
> @@ -1,3 +1,8 @@
> +2012-11-07  Vladimir Makarov  <vmakarov@redhat.com>
> +
> +       PR rtl-optimization/55151
> +       * gcc.dg/pr55151.c: Use ia32 instead of x86_64.
> +

Lots of constraints there that might not be suitable for all
machines.  Unless it's expected to pass (almost) everywhere, it
should move to gcc.target/i386.

If it *is* expected to pass everywhere,
at least add /* { dg-require-effective-target fpic } */
or similar (can be done in the target expression).

brgds, H-P
Vladimir Makarov - Nov. 9, 2012, 2:30 p.m.
On 12-11-08 11:59 AM, Hans-Peter Nilsson wrote:
> On Wed, 7 Nov 2012, Vladimir Makarov wrote:
>> On 12-11-07 5:27 PM, H.J. Lu wrote:
>>> You should check !ia32 target:
>>>
>>> /* { dg-do compile { target { ! { ia32 } } } } */
>>>
>>>
>> Thanks, H.J.  I've just fixed it.
>>
>> Index: testsuite/ChangeLog
>> ===================================================================
>> --- testsuite/ChangeLog (revision 193316)
>> +++ testsuite/ChangeLog (working copy)
>> @@ -1,3 +1,8 @@
>> +2012-11-07  Vladimir Makarov  <vmakarov@redhat.com>
>> +
>> +       PR rtl-optimization/55151
>> +       * gcc.dg/pr55151.c: Use ia32 instead of x86_64.
>> +
> Lots of constraints there that might not be suitable for all
> machines.  Unless it's expected to pass (almost) everywhere, it
> should move to gcc.target/i386.
>
I am agree it is better not to run it on any target.  I've moved it to 
gcc.target/i386.

Thanks for pointing this out.

Patch

Index: testsuite/ChangeLog
===================================================================
--- testsuite/ChangeLog (revision 193316)
+++ testsuite/ChangeLog (working copy)
@@ -1,3 +1,8 @@ 
+2012-11-07  Vladimir Makarov  <vmakarov@redhat.com>
+
+       PR rtl-optimization/55151
+       * gcc.dg/pr55151.c: Use ia32 instead of x86_64.
+
  2012-11-05  Uros Bizjak  <ubizjak@gmail.com>

         * gcc.dg/tree-ssa/cunroll-1.c: Scan cunrolli dump.
Index: testsuite/gcc.dg/pr55151.c
===================================================================
--- testsuite/gcc.dg/pr55151.c  (revision 193316)
+++ testsuite/gcc.dg/pr55151.c  (working copy)
@@ -1,5 +1,5 @@ 
  /* PR rtl-optimization/55151 */
-/* { dg-do compile  { target x86_64-*-* } } */
+/* { dg-do compile  { target { ! { ia32 } } } } */
  /* { dg-options "-fPIC" } */

  int a, b, c, d, e, f, g, h, i, j, k, l;