From patchwork Wed Nov 7 13:45:46 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vipul Pandya X-Patchwork-Id: 197672 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3A7652C00C8 for ; Thu, 8 Nov 2012 00:49:29 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752735Ab2KGNt1 (ORCPT ); Wed, 7 Nov 2012 08:49:27 -0500 Received: from stargate.chelsio.com ([67.207.112.58]:31313 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281Ab2KGNt0 (ORCPT ); Wed, 7 Nov 2012 08:49:26 -0500 Received: from maui.asicdesigners.com (maui.asicdesigners.com [10.192.180.15]) by stargate.chelsio.com (8.13.1/8.13.1) with SMTP id qA7DnPHD021779; Wed, 7 Nov 2012 05:49:25 -0800 Received: from strawberry ([10.193.185.96]) by maui.asicdesigners.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 7 Nov 2012 05:49:24 -0800 From: Vipul Pandya To: netdev@vger.kernel.org Cc: davem@davemloft.net, divy@chelsio.com, dm@chelsio.com, Vipul Pandya , Jay Hernandez Subject: [PATCH net] cxgb4: Fix initialization of SGE_CONTROL register Date: Wed, 7 Nov 2012 19:15:46 +0530 Message-Id: <1352295946-32146-1-git-send-email-vipul@chelsio.com> X-Mailer: git-send-email 1.7.1 X-OriginalArrivalTime: 07 Nov 2012 13:49:24.0367 (UTC) FILETIME=[B25389F0:01CDBCEE] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org INGPADBOUNDARY_MASK is already shifted. No need to shift it again. On reloading a driver it was resulting in a bad SGE FL MTU sizes [1536, 9088] error. This only causes an issue on systems that have L1 cache size of 32B, 128B, 512B, 2048B or 4096B. Signed-off-by: Jay Hernandez Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index 01fa5b7..730ae2c 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c @@ -2831,7 +2831,7 @@ int t4_fixup_host_params(struct adapter *adap, unsigned int page_size, HOSTPAGESIZEPF7(sge_hps)); t4_set_reg_field(adap, SGE_CONTROL, - INGPADBOUNDARY(INGPADBOUNDARY_MASK) | + INGPADBOUNDARY_MASK | EGRSTATUSPAGESIZE_MASK, INGPADBOUNDARY(fl_align_log - 5) | EGRSTATUSPAGESIZE(stat_len != 64));