Patchwork [02/11] CheckInTests: More clean up

login
register
mail settings
Submitter Chuck Lever
Date Nov. 6, 2012, 5:33 p.m.
Message ID <20121106173311.26310.78312.stgit@seurat.1015granger.net>
Download mbox | patch
Permalink /patch/197515/
State Accepted
Headers show

Comments

Chuck Lever - Nov. 6, 2012, 5:33 p.m.
Using the "-j" option on make should always work.  A multi-threaded
build is a good check that our Makefile dependencies are more or
less correct.

In addition, clean up the requirements around ./configure, and add
a "make distclean" requirement.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

 doc/CheckInTests |   17 ++++++++++-------
 1 files changed, 10 insertions(+), 7 deletions(-)

Patch

diff --git a/doc/CheckInTests b/doc/CheckInTests
index 37bc2ef..8a9043b 100644
--- a/doc/CheckInTests
+++ b/doc/CheckInTests
@@ -86,14 +86,17 @@  Per-commit acceptance tests
 This is basic stuff that's easy to run, and should be working for
 bisecting to be useful.
 
- 1.  "autogen.sh" and "configure" must run without error
- 2.  "CC=cgcc ./configure --enable-silent-rules; make -s" must complete
-     without error, and without new compiler or sparse warnings
- 3.  "make doxy" must complete with no errors or warnings
- 4.  "make distcheck" must complete without error
- 5.  "git status" must produce no output on a clean tree
- 6.  "git log -p" shows no new white space damage
+ 1.  "autogen.sh" must run without error
+ 2.  "CC=cgcc ./configure --enable-silent-rules --exec=/usr" must
+     complete successfully
+ 3.  "make -s -j3" must complete without error or new compiler
+     or sparse warnings
+ 4.  "make doxy" must complete with no errors or warnings
+ 5.  "make distcheck" must complete without error
+ 6.  "make distclean" must complete without error
  7.  "git clean -d -f -x" does not break anything
+ 8.  "git status" must produce no output on a clean tree
+ 9.  "git log -p" shows no new white space damage
 
 To preserve bisectability, the tree MUST build after each commit.