From patchwork Tue Nov 6 16:19:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/2] cpu: microcode: ensure we don't overflow with strncpy Date: Tue, 06 Nov 2012 06:19:29 -0000 From: Colin King X-Patchwork-Id: 197497 Message-Id: <1352218770-13472-2-git-send-email-colin.king@canonical.com> To: fwts-devel@lists.ubuntu.com From: Colin Ian King Signed-off-by: Colin Ian King Acked-by: Keng-Yu Lin Acked-by: Alex Hung --- src/cpu/microcode/microcode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cpu/microcode/microcode.c b/src/cpu/microcode/microcode.c index 50b19e1..7d9a607 100644 --- a/src/cpu/microcode/microcode.c +++ b/src/cpu/microcode/microcode.c @@ -75,7 +75,8 @@ static void gather_info(fwts_framework *fw, fwts_list *cpus) fwts_log_error(fw, "Cannot allocate memory."); break; } - strncpy(cpu->cpu, entry->d_name, 16); + strncpy(cpu->cpu, entry->d_name, sizeof(cpu->cpu) - 1); + cpu->cpu[sizeof(cpu->cpu) - 1] = '\0'; cpu->version = strtoul(data, NULL, 16); free(data); fwts_list_append(cpus, cpu);