Patchwork add new package fxload

login
register
mail settings
Submitter Jeremy Rosen
Date Nov. 6, 2012, 10:50 a.m.
Message ID <1352199012-7746-1-git-send-email-jeremy.rosen@openwide.fr>
Download mbox | patch
Permalink /patch/197461/
State Accepted
Commit 7103905fdeb4a92e4572045e16396e53cd1bf749
Headers show

Comments

Jeremy Rosen - Nov. 6, 2012, 10:50 a.m.
Signed-off-by: Jérémy Rosen <jeremy.rosen@openwide.fr>
---
v2: Incorporated comments from Arnout,

I am not sure about the make install target line,

I would have expected prefix= to be set by the environement, but maybe it is not a standard var name for make...
---
 package/Config.in        |    1 +
 package/fxload/Config.in |    9 +++++++++
 package/fxload/fxload.mk |   19 +++++++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 package/fxload/Config.in
 create mode 100644 package/fxload/fxload.mk
Arnout Vandecappelle - Nov. 7, 2012, 12:23 a.m.
On 06/11/12 11:50, Jérémy Rosen wrote:
> Signed-off-by: Jérémy Rosen<jeremy.rosen@openwide.fr>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

> ---
> v2: Incorporated comments from Arnout,

  Yep, this is the way to separate additional comments from the commit message.

>
> I am not sure about the make install target line,
>
> I would have expected prefix= to be set by the environement, but maybe it is not a standard var name for make...

  Nope.  The usual variable is DESTDIR.  I guess in fxload they have chosen prefix
because it's similar to 'configure --prefix'.

  Regards,
  Arnout

[snip]
Peter Korsgaard - Nov. 7, 2012, 9:49 a.m.
>>>>> "Jérémy" == Jérémy Rosen <jeremy.rosen@openwide.fr> writes:

 Jérémy> Signed-off-by: Jérémy Rosen <jeremy.rosen@openwide.fr>
 Jérémy> ---
 Jérémy> v2: Incorporated comments from Arnout,

Committed, thanks.
Jeremy Rosen - Nov. 7, 2012, 10 a.m.
yay, my first commit to buildroot :)

fight key loggers : write some perl using vim

----- Mail original -----
> De: "Peter Korsgaard" <jacmet@uclibc.org>
> À: "Jérémy Rosen" <jeremy.rosen@openwide.fr>
> Cc: buildroot@busybox.net
> Envoyé: Mercredi 7 Novembre 2012 10:49:51
> Objet: Re: [PATCH] add new package fxload
> 
> >>>>> "Jérémy" == Jérémy Rosen <jeremy.rosen@openwide.fr> writes:
> 
>  Jérémy> Signed-off-by: Jérémy Rosen <jeremy.rosen@openwide.fr>
>  Jérémy> ---
>  Jérémy> v2: Incorporated comments from Arnout,
> 
> Committed, thanks.
> 
> --
> Bye, Peter Korsgaard
>

Patch

diff --git a/package/Config.in b/package/Config.in
index e531c41..bcd1b47 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -211,6 +211,7 @@  source "package/flashrom/Config.in"
 source "package/fconfig/Config.in"
 source "package/fis/Config.in"
 source "package/fmtools/Config.in"
+source "package/fxload/Config.in"
 source "package/gadgetfs-test/Config.in"
 source "package/gdisk/Config.in"
 source "package/gpsd/Config.in"
diff --git a/package/fxload/Config.in b/package/fxload/Config.in
new file mode 100644
index 0000000..ac190f0
--- /dev/null
+++ b/package/fxload/Config.in
@@ -0,0 +1,9 @@ 
+config BR2_PACKAGE_FXLOAD
+	bool "fxload"
+	help
+	  This program is conveniently able to download firmware into FX, FX2,
+	  and FX2LP EZ-USB devices, as well as the original AnchorChips EZ-USB.
+	  It is intended to be invoked by hotplug scripts when the unprogrammed
+	  device appears on the bus.
+
+	  http://sourceforge.net/projects/linux-hotplug/
diff --git a/package/fxload/fxload.mk b/package/fxload/fxload.mk
new file mode 100644
index 0000000..1b5e8c7
--- /dev/null
+++ b/package/fxload/fxload.mk
@@ -0,0 +1,19 @@ 
+#############################################################
+#
+# fxload
+#
+#############################################################
+FXLOAD_VERSION = 2008_10_13
+FXLOAD_SITE = http://downloads.sourceforge.net/project/linux-hotplug/fxload/$(FXLOAD_VERSION)
+FXLOAD_LICENSE = GPLv2+
+FXLOAD_LICENSE_FILE = COPYING
+
+define FXLOAD_BUILD_CMDS
+    $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) all
+endef
+
+define FXLOAD_INSTALL_TARGET_CMDS
+    $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) prefix=$(TARGET_DIR) -C $(@D) install
+endef
+
+$(eval $(generic-package))