Patchwork [8/9] petitboot: Make client ops constant

login
register
mail settings
Submitter Geoff Levand
Date Jan. 22, 2009, 12:27 a.m.
Message ID <20090122002653.752490070@am.sony.com>
Download mbox | patch
Permalink /patch/19745/
State Accepted
Delegated to: Jeremy Kerr
Headers show

Comments

Geoff Levand - Jan. 22, 2009, 12:27 a.m.
Make the discover_client_ops args read-only.

Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
 ui/common/discover-client.c |    5 +++--
 ui/common/discover-client.h |    9 +++++----
 ui/test/pb-test.c           |    5 +++--
 3 files changed, 11 insertions(+), 8 deletions(-)

Patch

--- a/ui/common/discover-client.c
+++ b/ui/common/discover-client.c
@@ -30,7 +30,8 @@  static int discover_client_destructor(vo
 	return 0;
 }
 
-struct discover_client* discover_client_init(struct discover_client_ops *ops)
+struct discover_client* discover_client_init(
+	const struct discover_client_ops *ops)
 {
 	struct discover_client *client;
 	struct sockaddr_un addr;
@@ -64,7 +65,7 @@  out_err:
 	return NULL;
 }
 
-int discover_client_get_fd(struct discover_client *client)
+int discover_client_get_fd(const struct discover_client *client)
 {
 	return client->fd;
 }
--- a/ui/common/discover-client.h
+++ b/ui/common/discover-client.h
@@ -13,14 +13,15 @@  struct discover_client;
  */
 
 struct discover_client_ops {
-	int (*add_device)(struct device *device, void *arg);
-	void (*remove_device)(char *dev_id, void *arg);
+	int (*add_device)(const struct device *device, void *arg);
+	void (*remove_device)(const char *dev_id, void *arg);
 	void *cb_arg;
 };
 
-struct discover_client *discover_client_init(struct discover_client_ops *ops);
+struct discover_client *discover_client_init(
+	const struct discover_client_ops *ops);
 
-int discover_client_get_fd(struct discover_client *client);
+int discover_client_get_fd(const struct discover_client *client);
 
 void discover_client_destroy(struct discover_client *client);
 
--- a/ui/test/pb-test.c
+++ b/ui/test/pb-test.c
@@ -3,7 +3,7 @@ 
 
 #include "ui/common/discover-client.h"
 
-static int print_device_add(struct device *device,
+static int print_device_add(const struct device *device,
 	void __attribute__((unused)) *arg)
 {
 	struct boot_option *opt;
@@ -28,7 +28,8 @@  static int print_device_add(struct devic
 	return 0;
 }
 
-static void print_device_remove(char *dev_id, void __attribute__((unused)) *arg)
+static void print_device_remove(const char *dev_id,
+	void __attribute__((unused)) *arg)
 {
 	printf("removed device:\n");
 	printf("\tid:   %s\n", dev_id);