From patchwork Tue Nov 6 02:30:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Shade X-Patchwork-Id: 197394 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from maxx.maxx.shmoo.com (maxx.shmoo.com [205.134.188.171]) by ozlabs.org (Postfix) with ESMTP id BE73B2C007F for ; Tue, 6 Nov 2012 13:30:59 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id 52BF69D1DD; Mon, 5 Nov 2012 21:30:57 -0500 (EST) X-Virus-Scanned: amavisd-new at maxx.shmoo.com Received: from maxx.maxx.shmoo.com ([127.0.0.1]) by localhost (maxx.shmoo.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R2L9H4Ns3GHd; Mon, 5 Nov 2012 21:30:57 -0500 (EST) Received: from maxx.shmoo.com (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id 01B2D9C1DD; Mon, 5 Nov 2012 21:30:52 -0500 (EST) X-Original-To: mailman-post+hostap@maxx.shmoo.com Delivered-To: mailman-post+hostap@maxx.shmoo.com Received: from localhost (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id 30B279C1DD for ; Mon, 5 Nov 2012 21:30:51 -0500 (EST) X-Virus-Scanned: amavisd-new at maxx.shmoo.com Received: from maxx.maxx.shmoo.com ([127.0.0.1]) by localhost (maxx.shmoo.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ucqPq+u7Gk8I for ; Mon, 5 Nov 2012 21:30:46 -0500 (EST) Received: from mail-vb0-f44.google.com (mail-vb0-f44.google.com [209.85.212.44]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by maxx.maxx.shmoo.com (Postfix) with ESMTPS id 5921E9C1D2 for ; Mon, 5 Nov 2012 21:30:46 -0500 (EST) Received: by mail-vb0-f44.google.com with SMTP id fc26so9222574vbb.17 for ; Mon, 05 Nov 2012 18:30:46 -0800 (PST) Received: by 10.52.72.104 with SMTP id c8mr10105758vdv.20.1352169046033; Mon, 05 Nov 2012 18:30:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.58.18.163 with HTTP; Mon, 5 Nov 2012 18:30:25 -0800 (PST) In-Reply-To: <20121103100640.GF4138@w1.fi> References: <20121103100640.GF4138@w1.fi> From: Robert Shade Date: Mon, 5 Nov 2012 21:30:25 -0500 Message-ID: Subject: Re: [PATCH] dbus: don't quote scan_freq and freq_list To: hostap@lists.shmoo.com X-BeenThere: hostap@lists.shmoo.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: HostAP Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: hostap-bounces@lists.shmoo.com Errors-To: hostap-bounces@lists.shmoo.com scan_freq and freq_list are not parsed by wpa_config_parse_freqs if quoted Signed-hostap: Robert Shade --- wpa_supplicant/dbus/dbus_new_handlers.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) static dbus_bool_t should_quote_opt(const char *key) -- 1.7.1 On Sat, Nov 3, 2012 at 6:06 AM, Jouni Malinen wrote: > On Mon, Oct 29, 2012 at 10:08:12PM -0400, Robert Shade wrote: >> scan_freq and freq_list are not parsed by wpa_config_parse_freqs if quoted > > The change itself looks fine, but could you please read the top level > CONTRIBUTIONS file (*) and re-send this with the Signed-hostap: tag in > the commit log so that I can apply it? > > (*) > http://w1.fi/gitweb/gitweb.cgi?p=hostap.git;a=blob_plain;f=CONTRIBUTIONS;hb=HEAD > > -- > Jouni Malinen PGP id EFC895FA > _______________________________________________ > HostAP mailing list > HostAP@lists.shmoo.com > http://lists.shmoo.com/mailman/listinfo/hostap diff --git a/wpa_supplicant/dbus/dbus_new_handlers.c b/wpa_supplicant/dbus/dbus_new_handlers.c index 00378be..4229157 100644 --- a/wpa_supplicant/dbus/dbus_new_handlers.c +++ b/wpa_supplicant/dbus/dbus_new_handlers.c @@ -124,7 +124,7 @@ DBusMessage * wpas_dbus_error_invalid_args(DBusMessage *message, static const char *dont_quote[] = { "key_mgmt", "proto", "pairwise", "auth_alg", "group", "eap", "opensc_engine_path", "pkcs11_engine_path", "pkcs11_module_path", - "bssid", NULL + "bssid", "scan_freq", "freq_list", NULL };