From patchwork Tue Nov 6 02:30:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: dbus: don't quote scan_freq and freq_list Date: Mon, 05 Nov 2012 16:30:25 -0000 From: Robert Shade X-Patchwork-Id: 197394 Message-Id: To: hostap@lists.shmoo.com scan_freq and freq_list are not parsed by wpa_config_parse_freqs if quoted Signed-hostap: Robert Shade --- wpa_supplicant/dbus/dbus_new_handlers.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) static dbus_bool_t should_quote_opt(const char *key) -- 1.7.1 On Sat, Nov 3, 2012 at 6:06 AM, Jouni Malinen wrote: > On Mon, Oct 29, 2012 at 10:08:12PM -0400, Robert Shade wrote: >> scan_freq and freq_list are not parsed by wpa_config_parse_freqs if quoted > > The change itself looks fine, but could you please read the top level > CONTRIBUTIONS file (*) and re-send this with the Signed-hostap: tag in > the commit log so that I can apply it? > > (*) > http://w1.fi/gitweb/gitweb.cgi?p=hostap.git;a=blob_plain;f=CONTRIBUTIONS;hb=HEAD > > -- > Jouni Malinen PGP id EFC895FA > _______________________________________________ > HostAP mailing list > HostAP@lists.shmoo.com > http://lists.shmoo.com/mailman/listinfo/hostap diff --git a/wpa_supplicant/dbus/dbus_new_handlers.c b/wpa_supplicant/dbus/dbus_new_handlers.c index 00378be..4229157 100644 --- a/wpa_supplicant/dbus/dbus_new_handlers.c +++ b/wpa_supplicant/dbus/dbus_new_handlers.c @@ -124,7 +124,7 @@ DBusMessage * wpas_dbus_error_invalid_args(DBusMessage *message, static const char *dont_quote[] = { "key_mgmt", "proto", "pairwise", "auth_alg", "group", "eap", "opensc_engine_path", "pkcs11_engine_path", "pkcs11_module_path", - "bssid", NULL + "bssid", "scan_freq", "freq_list", NULL };