Patchwork dbus: don't quote scan_freq and freq_list

login
register
mail settings
Submitter Robert Shade
Date Nov. 6, 2012, 2:30 a.m.
Message ID <CAMgrJ3b42D-THju1gZ5v6_RzXE6x1-kCrW8wFcUDSnm9cbYGNQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/197394/
State Accepted
Commit 99276998fa26d4299825eeafb6386fe1c51f6287
Headers show

Comments

Robert Shade - Nov. 6, 2012, 2:30 a.m.
scan_freq and freq_list are not parsed by wpa_config_parse_freqs if quoted

Signed-hostap: Robert Shade <robert.shade@gmail.com>

---
 wpa_supplicant/dbus/dbus_new_handlers.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

 static dbus_bool_t should_quote_opt(const char *key)
--
1.7.1

On Sat, Nov 3, 2012 at 6:06 AM, Jouni Malinen <j@w1.fi> wrote:
> On Mon, Oct 29, 2012 at 10:08:12PM -0400, Robert Shade wrote:
>> scan_freq and freq_list are not parsed by wpa_config_parse_freqs if quoted
>
> The change itself looks fine, but could you please read the top level
> CONTRIBUTIONS file (*) and re-send this with the Signed-hostap: tag in
> the commit log so that I can apply it?
>
> (*)
> http://w1.fi/gitweb/gitweb.cgi?p=hostap.git;a=blob_plain;f=CONTRIBUTIONS;hb=HEAD
>
> --
> Jouni Malinen                                            PGP id EFC895FA
> _______________________________________________
> HostAP mailing list
> HostAP@lists.shmoo.com
> http://lists.shmoo.com/mailman/listinfo/hostap
Jouni Malinen - Nov. 11, 2012, 2:22 p.m.
On Mon, Nov 05, 2012 at 09:30:25PM -0500, Robert Shade wrote:
> scan_freq and freq_list are not parsed by wpa_config_parse_freqs if quoted

Thanks, applied.

Patch

diff --git a/wpa_supplicant/dbus/dbus_new_handlers.c
b/wpa_supplicant/dbus/dbus_new_handlers.c
index 00378be..4229157 100644
--- a/wpa_supplicant/dbus/dbus_new_handlers.c
+++ b/wpa_supplicant/dbus/dbus_new_handlers.c
@@ -124,7 +124,7 @@  DBusMessage *
wpas_dbus_error_invalid_args(DBusMessage *message,
 static const char *dont_quote[] = {
  "key_mgmt", "proto", "pairwise", "auth_alg", "group", "eap",
  "opensc_engine_path", "pkcs11_engine_path", "pkcs11_module_path",
- "bssid", NULL
+ "bssid", "scan_freq", "freq_list", NULL
 };