Patchwork [2/3] data: klog.json: Add support for the x86 MTRR kernel messages

login
register
mail settings
Submitter Colin King
Date Nov. 5, 2012, 6:37 p.m.
Message ID <1352140636-14986-3-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/197270/
State Accepted
Headers show

Comments

Colin King - Nov. 5, 2012, 6:37 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add support to check for messages in arch/x86/kernel/cpu/mtrr/generic.c

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)
Keng-Yu Lin - Nov. 8, 2012, 3:01 a.m.
On Mon, Nov 5, 2012 at 7:37 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in arch/x86/kernel/cpu/mtrr/generic.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 5007857..7211907 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -78,6 +78,22 @@
>   [
>    {
>     "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_LOW",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "MTRR.*CPU.*SYSCFG.*MtrrFixDramModEn.*not cleared by BIOS, clearing this bit",
> +   "advice": "The firmware is expected to clear MtrrFixDramModEn bit, see for example BIOS and Kernel Developer's Guide for the AMD Athlon 64 and AMD Opteron Processors (26094 Rev. 3.30 February 2006), section 13.2.1.2 SYSCFG Register. The MtrrFixDramModEn bit should be set 1 during firmware initalization of the fixed MTRRs, then cleared to 0 for operation. Hence the kernel has detected and worked around this fault.",
> +   "label": "KlogMtrrFixDramModEnNotClear"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "MTRR.*CPU.*Writing MSR .* to .* failed",
> +   "advice": "Writing to a MTRR MSR has failed. The kernel cannot do much about this and has ignored the failure.",
> +   "label": "KlogMtrrWriteMsrFailed"
> +  },
> +  {
> +   "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI",
>     "pattern": "acpi_request_vector.*invalid interrupt type",
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Nov. 21, 2012, 3:05 a.m.
On 11/06/2012 02:37 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in arch/x86/kernel/cpu/mtrr/generic.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |   16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 5007857..7211907 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -78,6 +78,22 @@
>    [
>     {
>      "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_LOW",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "MTRR.*CPU.*SYSCFG.*MtrrFixDramModEn.*not cleared by BIOS, clearing this bit",
> +   "advice": "The firmware is expected to clear MtrrFixDramModEn bit, see for example BIOS and Kernel Developer's Guide for the AMD Athlon 64 and AMD Opteron Processors (26094 Rev. 3.30 February 2006), section 13.2.1.2 SYSCFG Register. The MtrrFixDramModEn bit should be set 1 during firmware initalization of the fixed MTRRs, then cleared to 0 for operation. Hence the kernel has detected and worked around this fault.",
> +   "label": "KlogMtrrFixDramModEnNotClear"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "MTRR.*CPU.*Writing MSR .* to .* failed",
> +   "advice": "Writing to a MTRR MSR has failed. The kernel cannot do much about this and has ignored the failure.",
> +   "label": "KlogMtrrWriteMsrFailed"
> +  },
> +  {
> +   "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI",
>      "pattern": "acpi_request_vector.*invalid interrupt type",
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 5007857..7211907 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -78,6 +78,22 @@ 
  [
   {
    "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_LOW",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "MTRR.*CPU.*SYSCFG.*MtrrFixDramModEn.*not cleared by BIOS, clearing this bit",
+   "advice": "The firmware is expected to clear MtrrFixDramModEn bit, see for example BIOS and Kernel Developer's Guide for the AMD Athlon 64 and AMD Opteron Processors (26094 Rev. 3.30 February 2006), section 13.2.1.2 SYSCFG Register. The MtrrFixDramModEn bit should be set 1 during firmware initalization of the fixed MTRRs, then cleared to 0 for operation. Hence the kernel has detected and worked around this fault.",
+   "label": "KlogMtrrFixDramModEnNotClear"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "MTRR.*CPU.*Writing MSR .* to .* failed",
+   "advice": "Writing to a MTRR MSR has failed. The kernel cannot do much about this and has ignored the failure.",
+   "label": "KlogMtrrWriteMsrFailed"
+  },
+  {
+   "compare_mode": "regex",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI",
    "pattern": "acpi_request_vector.*invalid interrupt type",