Patchwork [1/3] data: klog.json: Add support for the ia64 ACPI handler.

login
register
mail settings
Submitter Colin King
Date Nov. 5, 2012, 6:37 p.m.
Message ID <1352140636-14986-2-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/197269/
State Accepted
Headers show

Comments

Colin King - Nov. 5, 2012, 6:37 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add support to check for messages in arch/ia64/kernel/acpi.c

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |   64 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)
Keng-Yu Lin - Nov. 8, 2012, 3 a.m.
On Mon, Nov 5, 2012 at 7:37 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in arch/ia64/kernel/acpi.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |   64 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 64 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index b4228f6..5007857 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -80,6 +80,70 @@
>     "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI",
> +   "pattern": "acpi_request_vector.*invalid interrupt type",
> +   "advice": "An attempt to request an interrupt vector greater than 256 (ACPI_MAX_PLATFORM_INTERRUPTS) has occurred and will be rejected.",
> +   "label": "KlogAcpiIa64RequestBadVector"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Can't find MADT",
> +   "advice": "Could not find the ACPI MADT. The kernel could not find this table so it could determine how many CPUs the system had.  The machine will boot with just one CPU which may be the incorrect number of CPUs.",
> +   "label": "KlogAcpiMadtMissing"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Error parsing MADT - no LAPIC entries",
> +   "advice": "The ACPI MADT could not be parsed to determine the number of Local APIC entries.  This may lead to sub-optimal configuration of the machine.",
> +   "label": "KlogAcpiMadtLapicParseError"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Error parsing LAPIC address override entry",
> +   "advice": "The ACPI MADT could not be parsed to determine the Local APIC override entry.",
> +   "label": "KlogAcpiMadtLapiceOverrideParseError"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Error parsing LAPIC NMI entry",
> +   "advice": "The ACPI MADT could not be parsed to determine the Local APIC NMI entry.",
> +   "label": "KlogAcpiMadtLapicNmiParseError"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Error parsing MADT.*no IOSAPIC entries",
> +   "advice": "The ACPI MADT could not be parsed to find the IOSAPIC entries.",
> +   "label": "KlogAcpiMadtIosapicParseError"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Error parsing platform interrupt source entry",
> +   "advice": "The ACPI MADT could not be parsed to find the platform intrerrupt source entry.",
> +   "label": "KlogAcpiMadtPlatIntSrcParseError"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Can't find FADT",
> +   "advice": "The ACPI Fixed ACPI Description Table (FADT) is missing and so the kernel cannot determine if the legacy keyboard controller is present.  It cannot also determine the SCI_INT interrupt line which is used for ACPI events, such as the power and sleep buttons. If the SCI_INT is not on a legacy interrupt then it needs to be specified in the FADT. ",
> +   "label": "KlogAcpiFadtMissing"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
>     "pattern": "ACPI.*Cannot create",
>     "advice": "The ACPI driver attempted to create an entry in /proc/acpi but failed. This should not happen and is a kernel bug.",
>     "label": "KlogAcpiProcfsCreateFailed"
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Nov. 21, 2012, 3:05 a.m.
On 11/06/2012 02:37 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in arch/ia64/kernel/acpi.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |   64 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 64 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index b4228f6..5007857 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -80,6 +80,70 @@
>      "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI",
> +   "pattern": "acpi_request_vector.*invalid interrupt type",
> +   "advice": "An attempt to request an interrupt vector greater than 256 (ACPI_MAX_PLATFORM_INTERRUPTS) has occurred and will be rejected.",
> +   "label": "KlogAcpiIa64RequestBadVector"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Can't find MADT",
> +   "advice": "Could not find the ACPI MADT. The kernel could not find this table so it could determine how many CPUs the system had.  The machine will boot with just one CPU which may be the incorrect number of CPUs.",
> +   "label": "KlogAcpiMadtMissing"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Error parsing MADT - no LAPIC entries",
> +   "advice": "The ACPI MADT could not be parsed to determine the number of Local APIC entries.  This may lead to sub-optimal configuration of the machine.",
> +   "label": "KlogAcpiMadtLapicParseError"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Error parsing LAPIC address override entry",
> +   "advice": "The ACPI MADT could not be parsed to determine the Local APIC override entry.",
> +   "label": "KlogAcpiMadtLapiceOverrideParseError"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Error parsing LAPIC NMI entry",
> +   "advice": "The ACPI MADT could not be parsed to determine the Local APIC NMI entry.",
> +   "label": "KlogAcpiMadtLapicNmiParseError"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Error parsing MADT.*no IOSAPIC entries",
> +   "advice": "The ACPI MADT could not be parsed to find the IOSAPIC entries.",
> +   "label": "KlogAcpiMadtIosapicParseError"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Error parsing platform interrupt source entry",
> +   "advice": "The ACPI MADT could not be parsed to find the platform intrerrupt source entry.",
> +   "label": "KlogAcpiMadtPlatIntSrcParseError"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "ACPI.*Can't find FADT",
> +   "advice": "The ACPI Fixed ACPI Description Table (FADT) is missing and so the kernel cannot determine if the legacy keyboard controller is present.  It cannot also determine the SCI_INT interrupt line which is used for ACPI events, such as the power and sleep buttons. If the SCI_INT is not on a legacy interrupt then it needs to be specified in the FADT. ",
> +   "label": "KlogAcpiFadtMissing"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
>      "pattern": "ACPI.*Cannot create",
>      "advice": "The ACPI driver attempted to create an entry in /proc/acpi but failed. This should not happen and is a kernel bug.",
>      "label": "KlogAcpiProcfsCreateFailed"
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index b4228f6..5007857 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -80,6 +80,70 @@ 
    "compare_mode": "regex",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI",
+   "pattern": "acpi_request_vector.*invalid interrupt type",
+   "advice": "An attempt to request an interrupt vector greater than 256 (ACPI_MAX_PLATFORM_INTERRUPTS) has occurred and will be rejected.",
+   "label": "KlogAcpiIa64RequestBadVector"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "ACPI.*Can't find MADT",
+   "advice": "Could not find the ACPI MADT. The kernel could not find this table so it could determine how many CPUs the system had.  The machine will boot with just one CPU which may be the incorrect number of CPUs.",
+   "label": "KlogAcpiMadtMissing"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "ACPI.*Error parsing MADT - no LAPIC entries",
+   "advice": "The ACPI MADT could not be parsed to determine the number of Local APIC entries.  This may lead to sub-optimal configuration of the machine.",
+   "label": "KlogAcpiMadtLapicParseError"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "ACPI.*Error parsing LAPIC address override entry",
+   "advice": "The ACPI MADT could not be parsed to determine the Local APIC override entry.",
+   "label": "KlogAcpiMadtLapiceOverrideParseError"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "ACPI.*Error parsing LAPIC NMI entry",
+   "advice": "The ACPI MADT could not be parsed to determine the Local APIC NMI entry.",
+   "label": "KlogAcpiMadtLapicNmiParseError"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "ACPI.*Error parsing MADT.*no IOSAPIC entries",
+   "advice": "The ACPI MADT could not be parsed to find the IOSAPIC entries.",
+   "label": "KlogAcpiMadtIosapicParseError"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "ACPI.*Error parsing platform interrupt source entry",
+   "advice": "The ACPI MADT could not be parsed to find the platform intrerrupt source entry.",
+   "label": "KlogAcpiMadtPlatIntSrcParseError"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "ACPI.*Can't find FADT",
+   "advice": "The ACPI Fixed ACPI Description Table (FADT) is missing and so the kernel cannot determine if the legacy keyboard controller is present.  It cannot also determine the SCI_INT interrupt line which is used for ACPI events, such as the power and sleep buttons. If the SCI_INT is not on a legacy interrupt then it needs to be specified in the FADT. ",
+   "label": "KlogAcpiFadtMissing"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
    "pattern": "ACPI.*Cannot create",
    "advice": "The ACPI driver attempted to create an entry in /proc/acpi but failed. This should not happen and is a kernel bug.",
    "label": "KlogAcpiProcfsCreateFailed"