Patchwork [3/3] data: klog.json: Add support for various BIOS and PnPBIOS kernel messages

login
register
mail settings
Submitter Colin King
Date Nov. 5, 2012, 6:37 p.m.
Message ID <1352140636-14986-4-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/197268/
State Accepted
Headers show

Comments

Colin King - Nov. 5, 2012, 6:37 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add support to check for messages in E820 driver and PnPBIOS driver

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |   48 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)
Keng-Yu Lin - Nov. 8, 2012, 3:01 a.m.
On Mon, Nov 5, 2012 at 7:37 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in E820 driver and PnPBIOS driver
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |   48 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 7211907..27d1211 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -78,6 +78,54 @@
>   [
>    {
>     "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "PnPBIOS.*ESCD size reported by BIOS escd_info call is too great",
> +   "advice": "The ESCD size was greater than a sane size of 32K.",
> +   "label": "KlogPnpBiosEscdSize"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "PnPBIOS.*ESCD size reported by BIOS read_escd call is too great",
> +   "advice": "The ESCD size was greater than a sane size of 32K.",
> +   "label": "KlogPnpBiosEscdSize"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "PnPBIOS.*",
> +   "advice": "The PnPBIOS driver has detected an issue that fwts does not know about.",
> +   "label": "KlogPnpBiosError"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "Node number .* is out of sequence following node .* Aborting.",
> +   "advice": "Device node numbers are out of sequence.",
> +   "label": "KlogPnpBiosDevNodeSeqError"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "PCI: BIOS BUG #",
> +   "advice": "A call to the PCI BIOS32 service routine (with service signature $PCI) has returned a bad status or an illegal PCI signature. The kernel will disable the use of the PCI BIOS.",
> +   "label": "KlogBios32PciFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "e820: too many entries; ignoring ",
> +   "advice": "Legacy E820 BIOS has a limit of 128 entries in the E820 memory map but the firmware seems to have more than this. For EFI Numa hardare, the limit is 128 + 3 * maximum number of nodes.  The kernel has ignore the extra entries.  This could lead to regions of memory being used by the kernel when in fact is should be reserved and this can lead to unexpected behaviour.",
> +   "label": "KlogE820TooManyEntries"
> +  },
> +  {
> +   "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_LOW",
>     "tag": "FWTS_TAG_ACPI",
>     "pattern": "MTRR.*CPU.*SYSCFG.*MtrrFixDramModEn.*not cleared by BIOS, clearing this bit",
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Nov. 21, 2012, 3:06 a.m.
On 11/06/2012 02:37 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in E820 driver and PnPBIOS driver
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |   48 ++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 48 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 7211907..27d1211 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -78,6 +78,54 @@
>    [
>     {
>      "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "PnPBIOS.*ESCD size reported by BIOS escd_info call is too great",
> +   "advice": "The ESCD size was greater than a sane size of 32K.",
> +   "label": "KlogPnpBiosEscdSize"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "PnPBIOS.*ESCD size reported by BIOS read_escd call is too great",
> +   "advice": "The ESCD size was greater than a sane size of 32K.",
> +   "label": "KlogPnpBiosEscdSize"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "PnPBIOS.*",
> +   "advice": "The PnPBIOS driver has detected an issue that fwts does not know about.",
> +   "label": "KlogPnpBiosError"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "Node number .* is out of sequence following node .* Aborting.",
> +   "advice": "Device node numbers are out of sequence.",
> +   "label": "KlogPnpBiosDevNodeSeqError"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "PCI: BIOS BUG #",
> +   "advice": "A call to the PCI BIOS32 service routine (with service signature $PCI) has returned a bad status or an illegal PCI signature. The kernel will disable the use of the PCI BIOS.",
> +   "label": "KlogBios32PciFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "e820: too many entries; ignoring ",
> +   "advice": "Legacy E820 BIOS has a limit of 128 entries in the E820 memory map but the firmware seems to have more than this. For EFI Numa hardare, the limit is 128 + 3 * maximum number of nodes.  The kernel has ignore the extra entries.  This could lead to regions of memory being used by the kernel when in fact is should be reserved and this can lead to unexpected behaviour.",
> +   "label": "KlogE820TooManyEntries"
> +  },
> +  {
> +   "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_LOW",
>      "tag": "FWTS_TAG_ACPI",
>      "pattern": "MTRR.*CPU.*SYSCFG.*MtrrFixDramModEn.*not cleared by BIOS, clearing this bit",
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 7211907..27d1211 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -78,6 +78,54 @@ 
  [
   {
    "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "PnPBIOS.*ESCD size reported by BIOS escd_info call is too great",
+   "advice": "The ESCD size was greater than a sane size of 32K.",
+   "label": "KlogPnpBiosEscdSize"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "PnPBIOS.*ESCD size reported by BIOS read_escd call is too great",
+   "advice": "The ESCD size was greater than a sane size of 32K.",
+   "label": "KlogPnpBiosEscdSize"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "PnPBIOS.*",
+   "advice": "The PnPBIOS driver has detected an issue that fwts does not know about.",
+   "label": "KlogPnpBiosError"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "Node number .* is out of sequence following node .* Aborting.",
+   "advice": "Device node numbers are out of sequence.",
+   "label": "KlogPnpBiosDevNodeSeqError"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_CRITICAL",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "PCI: BIOS BUG #",
+   "advice": "A call to the PCI BIOS32 service routine (with service signature $PCI) has returned a bad status or an illegal PCI signature. The kernel will disable the use of the PCI BIOS.",
+   "label": "KlogBios32PciFailed"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_CRITICAL",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "e820: too many entries; ignoring ",
+   "advice": "Legacy E820 BIOS has a limit of 128 entries in the E820 memory map but the firmware seems to have more than this. For EFI Numa hardare, the limit is 128 + 3 * maximum number of nodes.  The kernel has ignore the extra entries.  This could lead to regions of memory being used by the kernel when in fact is should be reserved and this can lead to unexpected behaviour.",
+   "label": "KlogE820TooManyEntries"
+  },
+  {
+   "compare_mode": "regex",
    "log_level": "LOG_LEVEL_LOW",
    "tag": "FWTS_TAG_ACPI",
    "pattern": "MTRR.*CPU.*SYSCFG.*MtrrFixDramModEn.*not cleared by BIOS, clearing this bit",