Patchwork [1/2] ubi-test/io_update: ubi_leb_change_start() no longer uses 'dtype'.

login
register
mail settings
Submitter Bill Pringlemeir
Date Nov. 5, 2012, 5:38 p.m.
Message ID <BLU0-SMTP90A53F512B3AC4BEA5374B8640@phx.gbl>
Download mbox | patch
Permalink /patch/197265/
State Accepted
Commit c557e71b1070e3282156c0466462975a95d0d05c
Headers show

Comments

Bill Pringlemeir - Nov. 5, 2012, 5:38 p.m.
This will not compile for me (due to bit rot?).  Maybe the program is
never used?

Signed-off-by: Bill Pringlemeir <bpringlemeir@nbsps.com>
---
 tests/ubi-tests/io_update.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Artem Bityutskiy - Nov. 16, 2012, 7:37 a.m.
On Mon, 2012-11-05 at 12:38 -0500, Bill Pringlemeir wrote:
> This will not compile for me (due to bit rot?).  Maybe the program is
> never used?
> 
> Signed-off-by: Bill Pringlemeir <bpringlemeir@nbsps.com>

It was used, but recently the dtype stuff was removed and the test was
not amended. Thanks, pushed to mtd-utils.git.

Patch

diff --git a/tests/ubi-tests/io_update.c b/tests/ubi-tests/io_update.c
index e8f0986..ec109e0 100644
--- a/tests/ubi-tests/io_update.c
+++ b/tests/ubi-tests/io_update.c
@@ -102,8 +102,7 @@  static int test_update1(struct ubi_vol_info *vol_info, int leb_change)
 		test_len = total_len - (rand() % (total_len / 10));
 
 		if (leb_change) {
-			if (ubi_leb_change_start(libubi, fd, 0, test_len,
-						 UBI_SHORTTERM)) {
+			if (ubi_leb_change_start(libubi, fd, 0, test_len)) {
 				failed("ubi_update_start");
 				goto close;
 			}