Patchwork [U-Boot,v2] net: Fix endianness bug in link-local

login
register
mail settings
Submitter Joe Hershberger
Date Nov. 5, 2012, 4:13 p.m.
Message ID <1352132025-8151-1-git-send-email-joe.hershberger@ni.com>
Download mbox | patch
Permalink /patch/197212/
State Accepted
Delegated to: Joe Hershberger
Headers show

Comments

Joe Hershberger - Nov. 5, 2012, 4:13 p.m.
The ip is stored in network order, so we can't test it in host order.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
---
Changes in v2:
- Changed htonl() to ntohl()

 net/link_local.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Kim Phillips - Nov. 5, 2012, 7:14 p.m.
On Mon, 5 Nov 2012 10:13:45 -0600
Joe Hershberger <joe.hershberger@ni.com> wrote:

> The ip is stored in network order, so we can't test it in host order.
> 
> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
> ---
> Changes in v2:
> - Changed htonl() to ntohl()

Reviewed-by: Kim Phillips <kim.phillips@freescale.com>

Kim

Patch

diff --git a/net/link_local.c b/net/link_local.c
index d52f13a..1ba796e 100644
--- a/net/link_local.c
+++ b/net/link_local.c
@@ -103,7 +103,7 @@  static void configure_wait(void)
 void link_local_start(void)
 {
 	ip = getenv_IPaddr("llipaddr");
-	if (ip != 0 && (ip & IN_CLASSB_NET) != LINKLOCAL_ADDR) {
+	if (ip != 0 && (ntohl(ip) & IN_CLASSB_NET) != LINKLOCAL_ADDR) {
 		puts("invalid link address");
 		net_set_state(NETLOOP_FAIL);
 		return;