Patchwork [1/2] Add missing dependency to netatalk

login
register
mail settings
Submitter Maxime Hadjinlian
Date Nov. 4, 2012, 7:25 p.m.
Message ID <1352057123-7137-1-git-send-email-maxime.hadjinlian@gmail.com>
Download mbox | patch
Permalink /patch/197087/
State Superseded
Headers show

Comments

Maxime Hadjinlian - Nov. 4, 2012, 7:25 p.m.
Netatalk need pkg-config, otherwise the configure script is complaining.
---
 package/netatalk/netatalk.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
1.7.10.4
Thomas Petazzoni - Nov. 5, 2012, 6:55 a.m.
Dear Maxime Hadjinlian,

On Sun,  4 Nov 2012 20:25:22 +0100, Maxime Hadjinlian wrote:

> -NETATALK_DEPENDENCIES = openssl berkeleydb libgcrypt libgpg-error
> +NETATALK_DEPENDENCIES = host-pkg-config openssl berkeleydb libgcrypt libgpg-error

host-pkg-config should now be host-pkgconf.

Peter, Arnout, shouldn't we be adding a dummy 'host-pkg-config' target
in order to avoid breaking all external packages that are using
host-pkg-config? Didn't we talk about not breaking APIs? :-)

Best regards,

Thomas
Arnout Vandecappelle - Nov. 5, 2012, 7:43 a.m.
On 11/05/12 07:55, Thomas Petazzoni wrote:
> Dear Maxime Hadjinlian,
>
> On Sun,  4 Nov 2012 20:25:22 +0100, Maxime Hadjinlian wrote:
>
>> -NETATALK_DEPENDENCIES = openssl berkeleydb libgcrypt libgpg-error
>> +NETATALK_DEPENDENCIES = host-pkg-config openssl berkeleydb libgcrypt libgpg-error
>
> host-pkg-config should now be host-pkgconf.
>
> Peter, Arnout, shouldn't we be adding a dummy 'host-pkg-config' target
> in order to avoid breaking all external packages that are using
> host-pkg-config? Didn't we talk about not breaking APIs? :-)

  Seems like a good idea.

  But I would make it issue an error, so people update their .mk files.

  Maybe we can create a top-level Makefile.legacy and Config.in.legacy that
collects all the API-compatibility-warnings-and-errors.  That makes it easier
to remove them later.

  Regards,
  Arnout
Peter Korsgaard - Nov. 5, 2012, 8:13 a.m.
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 >> host-pkg-config should now be host-pkgconf.
 >> 
 >> Peter, Arnout, shouldn't we be adding a dummy 'host-pkg-config' target
 >> in order to avoid breaking all external packages that are using
 >> host-pkg-config? Didn't we talk about not breaking APIs? :-)

 Arnout>  Seems like a good idea.

 Arnout>  But I would make it issue an error, so people update their .mk
 Arnout>  files.

 Arnout>  Maybe we can create a top-level Makefile.legacy and
 Arnout> Config.in.legacy that collects all the
 Arnout> API-compatibility-warnings-and-errors.  That makes it easier to
 Arnout> remove them later.

Sounds like a good idea. Care to cook up a patch?
Peter Korsgaard - Nov. 5, 2012, 8:14 a.m.
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

 Maxime> Netatalk need pkg-config, otherwise the configure script is complaining.

Next to the comment of Thomas, also remember to sign off on your patches
(-s argument to git commit).
Maxime Hadjinlian - Nov. 6, 2012, 8 a.m.
On Mon, Nov 5, 2012 at 9:14 AM, Peter Korsgaard <jacmet@uclibc.org> wrote:

> >>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:
>
>  Maxime> Netatalk need pkg-config, otherwise the configure script is
> complaining.
>
> Next to the comment of Thomas, also remember to sign off on your patches
> (-s argument to git commit).
>
> I'll resend this patch (and the second one as I also forgot to signed it)
after the ELC, my hotel connection doesn't seem to appreciate smtp and tls
:/

> --
> Bye, Peter Korsgaard
>

Patch

diff --git a/package/netatalk/netatalk.mk b/package/netatalk/netatalk.mk
index c01e360..4aa179e 100644
--- a/package/netatalk/netatalk.mk
+++ b/package/netatalk/netatalk.mk
@@ -7,7 +7,7 @@  NETATALK_VERSION = 3.0
 NETATALK_SITE = http://downloads.sourceforge.net/project/netatalk/netatalk/$(NETATALK_VERSION)
 NETATALK_SOURCE = netatalk-$(NETATALK_VERSION).tar.bz2

-NETATALK_DEPENDENCIES = openssl berkeleydb libgcrypt libgpg-error
+NETATALK_DEPENDENCIES = host-pkg-config openssl berkeleydb libgcrypt libgpg-error
 NETATALK_CONF_ENV += CC="$(TARGET_CC) -std=gnu99"
 NETATALK_CONF_OPT += --with-cnid-cdb-backend \
 	--with-bdb=$(STAGING_DIR)/usr \