Patchwork [5/8] powerpc/5200: Don't specify IRQF_SHARED in PSC UART driver

login
register
mail settings
Submitter Grant Likely
Date Jan. 21, 2009, 8:55 p.m.
Message ID <20090121205529.31232.64801.stgit@localhost.localdomain>
Download mbox | patch
Permalink /patch/19697/
State Accepted
Commit d9f0c5f9bc74f16d0ea0f6c518b209e48783a796
Delegated to: Grant Likely
Headers show

Comments

Grant Likely - Jan. 21, 2009, 8:55 p.m.
From: Grant Likely <grant.likely@secretlab.ca>

The MPC5200 PSC device is wired up to a dedicated interrupt line
which is never shared.  This patch removes the IRQF_SHARED flag
from the request_irq() call which eliminates the "IRQF_DISABLED
is not guaranteed on shared IRQs" warning message from the console
output.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---

 drivers/serial/mpc52xx_uart.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Wolfram Sang - Jan. 29, 2009, 9:24 p.m.
On Wed, Jan 21, 2009 at 01:55:29PM -0700, Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
> 
> The MPC5200 PSC device is wired up to a dedicated interrupt line
> which is never shared.  This patch removes the IRQF_SHARED flag
> from the request_irq() call which eliminates the "IRQF_DISABLED
> is not guaranteed on shared IRQs" warning message from the console
> output.
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

What do I give here? Acked-by? Reviewed? Tested? :D I'll make a guess:

Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>

> ---
> 
>  drivers/serial/mpc52xx_uart.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c
> index d73d7da..7f72f8c 100644
> --- a/drivers/serial/mpc52xx_uart.c
> +++ b/drivers/serial/mpc52xx_uart.c
> @@ -522,7 +522,7 @@ mpc52xx_uart_startup(struct uart_port *port)
>  
>  	/* Request IRQ */
>  	ret = request_irq(port->irq, mpc52xx_uart_int,
> -		IRQF_DISABLED | IRQF_SAMPLE_RANDOM | IRQF_SHARED,
> +		IRQF_DISABLED | IRQF_SAMPLE_RANDOM,
>  		"mpc52xx_psc_uart", port);
>  	if (ret)
>  		return ret;
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

Patch

diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c
index d73d7da..7f72f8c 100644
--- a/drivers/serial/mpc52xx_uart.c
+++ b/drivers/serial/mpc52xx_uart.c
@@ -522,7 +522,7 @@  mpc52xx_uart_startup(struct uart_port *port)
 
 	/* Request IRQ */
 	ret = request_irq(port->irq, mpc52xx_uart_int,
-		IRQF_DISABLED | IRQF_SAMPLE_RANDOM | IRQF_SHARED,
+		IRQF_DISABLED | IRQF_SAMPLE_RANDOM,
 		"mpc52xx_psc_uart", port);
 	if (ret)
 		return ret;