From patchwork Sat Nov 3 15:43:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 196861 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 55AE82C00B2 for ; Sun, 4 Nov 2012 02:46:57 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756715Ab2KCPqn (ORCPT ); Sat, 3 Nov 2012 11:46:43 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:45412 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756434Ab2KCPoX (ORCPT ); Sat, 3 Nov 2012 11:44:23 -0400 Received: by mail-pb0-f46.google.com with SMTP id rr4so3041498pbb.19 for ; Sat, 03 Nov 2012 08:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=GcYEfjffN4v5FaVeAwfD0M/5XnrJ4l12IlHn7zBO5hM=; b=pbCecPiDywQFwx4Qvuo1JhnrSXlw3j4d6WB2sAyD/I4E6qNB+pr4j4bfCjwvUceITs uitikMvEVu97DRrtlXZSxOwnoCHRcTFg4Xldd7DZYjeGccgNJjoiKCD5yqfRFjs7IhlA Y+eKr7/sZUqVZOcqLlahY88H+6B6YIgoLfhtgEbx/IYfyefoSWoyhP9o0hQg6/DQbPYB ZNIf7gBQ4nJ47U87kWmyuvvUzyt1ufIXRQTsT3YcGoUNDmGspRZWBWyDSNRK5OFXtKPJ lI9LUGJey9tQ3rJNy3wL3bJgizvz+N8f2lcgCi28rQ8kY8cHt+eCwuJ+TYjYgfDAIMnx DlIw== Received: by 10.68.226.136 with SMTP id rs8mr16039050pbc.153.1351957462663; Sat, 03 Nov 2012 08:44:22 -0700 (PDT) Received: from localhost.localdomain (p1120-ipbf2201hodogaya.kanagawa.ocn.ne.jp. [123.220.186.120]) by mx.google.com with ESMTPS id qi2sm7546049pbc.22.2012.11.03.08.44.21 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 03 Nov 2012 08:44:22 -0700 (PDT) From: Akinobu Mita To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: Akinobu Mita , Eilon Greenstein , netdev@vger.kernel.org Subject: [PATCH v2 03/11] bnx2x: use random32_get_bytes() Date: Sun, 4 Nov 2012 00:43:34 +0900 Message-Id: <1351957422-23243-4-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1351957422-23243-1-git-send-email-akinobu.mita@gmail.com> References: <1351957422-23243-1-git-send-email-akinobu.mita@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use random32_get_bytes() to fill rss key with pseudo-random bytes. Signed-off-by: Akinobu Mita Cc: Eilon Greenstein Cc: netdev@vger.kernel.org --- new patch from v2 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index 4833b6a..9a25658 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c @@ -1741,7 +1741,6 @@ int bnx2x_config_rss_pf(struct bnx2x *bp, struct bnx2x_rss_config_obj *rss_obj, bool config_hash) { struct bnx2x_config_rss_params params = {NULL}; - int i; /* Although RSS is meaningless when there is a single HW queue we * still need it enabled in order to have HW Rx hash generated. @@ -1773,9 +1772,7 @@ int bnx2x_config_rss_pf(struct bnx2x *bp, struct bnx2x_rss_config_obj *rss_obj, if (config_hash) { /* RSS keys */ - for (i = 0; i < sizeof(params.rss_key) / 4; i++) - params.rss_key[i] = random32(); - + random32_get_bytes(params.rss_key, sizeof(params.rss_key)); __set_bit(BNX2X_RSS_SET_SRCH, ¶ms.rss_flags); }