From patchwork Sat Nov 3 15:43:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 196852 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EDCFC2C00DA for ; Sun, 4 Nov 2012 02:46:09 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TUftj-0007gC-Lv; Sat, 03 Nov 2012 15:44:35 +0000 Received: from mail-pb0-f49.google.com ([209.85.160.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TUfta-0007eB-HL for linux-mtd@lists.infradead.org; Sat, 03 Nov 2012 15:44:27 +0000 Received: by mail-pb0-f49.google.com with SMTP id xa7so2829087pbc.36 for ; Sat, 03 Nov 2012 08:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=HHGUpJQ5aaZtypapGytXsnsjEqikTrETeXxI+IfezRc=; b=aAMDaoD3GWysG7vIJlSZaH6R4Kzo5fi/gM8LP7sYQmNE7+Jt7rSwZvILaVgKEu8K8U lWmRKCv8dIDe4YTyFSMYgpU9lE8EU0kvHOnqn0RuhR8Imijnh9H/XYKN0J2InxC8ffoe 7CZoWHQeLNM9DNHJpGR85KjADwUcz73xweonMDh1ctC7SrlwAoAe8hKoXgTdZdbn31Ng gUT4lNTiAQea7L0TNBjf4MPxoIhVZgc74SvAvbE963gGSW3qI4PRlQL1GXsbkgDKfuNz PFJ9WpTzxsd98rEwmA4yDfk0QxnHSDHbc5lUeh+f/gcb4NOh06wR8ZZoedt7KFiguCe1 xIMA== Received: by 10.66.76.98 with SMTP id j2mr14693373paw.65.1351957464745; Sat, 03 Nov 2012 08:44:24 -0700 (PDT) Received: from localhost.localdomain (p1120-ipbf2201hodogaya.kanagawa.ocn.ne.jp. [123.220.186.120]) by mx.google.com with ESMTPS id qi2sm7546049pbc.22.2012.11.03.08.44.22 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 03 Nov 2012 08:44:24 -0700 (PDT) From: Akinobu Mita To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: [PATCH v2 04/11] mtd: nandsim: use random32_get_bytes Date: Sun, 4 Nov 2012 00:43:35 +0900 Message-Id: <1351957422-23243-5-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1351957422-23243-1-git-send-email-akinobu.mita@gmail.com> References: <1351957422-23243-1-git-send-email-akinobu.mita@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121103_114426_686763_8892EAAF X-CRM114-Status: GOOD ( 11.05 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.160.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (akinobu.mita[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: linux-mtd@lists.infradead.org, David Woodhouse , Akinobu Mita , Artem Bityutskiy X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This also removes unnecessary memset call which is immediately overwritten with random bytes. Signed-off-by: Akinobu Mita Cc: Artem Bityutskiy Cc: David Woodhouse Cc: linux-mtd@lists.infradead.org --- no change from v1 drivers/mtd/nand/nandsim.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c index a932c48..d074b4c 100644 --- a/drivers/mtd/nand/nandsim.c +++ b/drivers/mtd/nand/nandsim.c @@ -1397,10 +1397,7 @@ int do_read_error(struct nandsim *ns, int num) unsigned int page_no = ns->regs.row; if (read_error(page_no)) { - int i; - memset(ns->buf.byte, 0xFF, num); - for (i = 0; i < num; ++i) - ns->buf.byte[i] = random32(); + random32_get_bytes(ns->buf.byte, num); NS_WARN("simulating read error in page %u\n", page_no); return 1; }