From patchwork Sat Nov 3 15:43:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2,04/11] mtd: nandsim: use random32_get_bytes Date: Sat, 03 Nov 2012 05:43:35 -0000 From: Akinobu Mita X-Patchwork-Id: 196852 Message-Id: <1351957422-23243-5-git-send-email-akinobu.mita@gmail.com> To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: linux-mtd@lists.infradead.org, David Woodhouse , Akinobu Mita , Artem Bityutskiy This also removes unnecessary memset call which is immediately overwritten with random bytes. Signed-off-by: Akinobu Mita Cc: Artem Bityutskiy Cc: David Woodhouse Cc: linux-mtd@lists.infradead.org --- no change from v1 drivers/mtd/nand/nandsim.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c index a932c48..d074b4c 100644 --- a/drivers/mtd/nand/nandsim.c +++ b/drivers/mtd/nand/nandsim.c @@ -1397,10 +1397,7 @@ int do_read_error(struct nandsim *ns, int num) unsigned int page_no = ns->regs.row; if (read_error(page_no)) { - int i; - memset(ns->buf.byte, 0xFF, num); - for (i = 0; i < num; ++i) - ns->buf.byte[i] = random32(); + random32_get_bytes(ns->buf.byte, num); NS_WARN("simulating read error in page %u\n", page_no); return 1; }