Patchwork Fix powerpc pr48258-2

login
register
mail settings
Submitter Michael Meissner
Date Nov. 2, 2012, 7:29 p.m.
Message ID <20121102192909.GA1497@ibm-tiger.the-meissners.org>
Download mbox | patch
Permalink /patch/196749/
State New
Headers show

Comments

Michael Meissner - Nov. 2, 2012, 7:29 p.m.
David pointed out to me that pr48258-2 was failing on AIX, and it was failing
under Linux as well.  In terms of the Linux failures, this was because the test
was failing if the xxsldwi was generated.  I decided the test conditions were
too specific, and loosened them to just check that the compiler did vectorize
the reductions, but not to count how many instructions were generated.

David does this also fix the AIX side of things and can be checked in?

[gcc/testsuite]
2012-11-02  Michael Meissner  <meissner@linux.vnet.ibm.com>

	* gcc.target/powerpc/pr48258-2.c: Simplfy the acceptance
	conditions to verify the reduction code is vectorized.
David Edelsohn - Nov. 2, 2012, 7:59 p.m.
On Fri, Nov 2, 2012 at 3:29 PM, Michael Meissner
<meissner@linux.vnet.ibm.com> wrote:
> David pointed out to me that pr48258-2 was failing on AIX, and it was failing
> under Linux as well.  In terms of the Linux failures, this was because the test
> was failing if the xxsldwi was generated.  I decided the test conditions were
> too specific, and loosened them to just check that the compiler did vectorize
> the reductions, but not to count how many instructions were generated.
>
> David does this also fix the AIX side of things and can be checked in?
>
> [gcc/testsuite]
> 2012-11-02  Michael Meissner  <meissner@linux.vnet.ibm.com>
>
>         * gcc.target/powerpc/pr48258-2.c: Simplfy the acceptance
>         conditions to verify the reduction code is vectorized.

This patch will fix AIX.

Please check it in.

Thanks, David

Patch

Index: gcc/testsuite/gcc.target/powerpc/pr48258-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/pr48258-2.c	(revision 193095)
+++ gcc/testsuite/gcc.target/powerpc/pr48258-2.c	(working copy)
@@ -1,17 +1,10 @@ 
 /* { dg-do compile } */
 /* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */
 /* { dg-require-effective-target powerpc_vsx_ok } */
-/* { dg-options "-O3 -mcpu=power7 -mabi=altivec -ffast-math -fno-unroll-loops" } */
-/* { dg-final { scan-assembler-times "xvadddp" 1 } } */
-/* { dg-final { scan-assembler-times "xvmindp" 1 } } */
-/* { dg-final { scan-assembler-times "xvmaxdp" 1 } } */
-/* { dg-final { scan-assembler-times "xsadddp" 1 } } */
-/* { dg-final { scan-assembler-times "xsmindp" 1 } } */
-/* { dg-final { scan-assembler-times "xsmaxdp" 1 } } */
-/* { dg-final { scan-assembler-not "xxsldwi" } } */
-/* { dg-final { scan-assembler-not "stvx" } } */
-/* { dg-final { scan-assembler-not "stxvd2x" } } */
-/* { dg-final { scan-assembler-not "stxvw4x" } } */
+/* { dg-options "-O3 -mcpu=power7 -mabi=altivec -ffast-math" } */
+/* { dg-final { scan-assembler "xvadddp" } } */
+/* { dg-final { scan-assembler "xvmindp" } } */
+/* { dg-final { scan-assembler "xvmaxdp" } } */
 
 #include <stddef.h>