Patchwork [18/22] data: klog.json: Add support for the ACPI video handler

login
register
mail settings
Submitter Colin King
Date Nov. 2, 2012, 5:15 p.m.
Message ID <1351876532-21869-19-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/196627/
State Accepted
Headers show

Comments

Colin King - Nov. 2, 2012, 5:15 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add support to check for messages in drivers/acpi/video.c

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |   32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
Keng-Yu Lin - Nov. 7, 2012, 4:19 a.m.
On Sat, Nov 3, 2012 at 1:15 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in drivers/acpi/video.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |   32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index bca1821..f211cb6 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -79,6 +79,38 @@
>    {
>     "compare_mode": "string",
>     "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_VIDEO",
> +   "pattern": "Failed to switch the brightness",
> +   "advice": "The ACPI video brightness for the LCD could not be set because _BCM failed.",
> +   "label": "KlogAcpiVideoBcmFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_VIDEO",
> +   "pattern": "Invalid _DOD data in element",
> +   "advice": "The ACPI _DOD control returned an element that was not an ACPI integer as expected. This element will be ignored, which could lead to reduced functionality.",
> +   "label": "KlogAcpiVideoDodFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_VIDEO",
> +   "pattern": "Invalid _DDC data",
> +   "advice": "The ACPI _DDC control is returning either a NULL buffer pointer or data that is not an ACPI buffer. The Extended Display Identification Data (EDID) structure that represents the display output device could not be fetched. This may affect video output.",
> +   "label": "KlogAcpiVideoDdcFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_VIDEO",
> +   "pattern": "Invalid _BCL data",
> +   "advice": "The ACPI _BCL control is returning either a NULL buffer pointer or data that is not an ACPI package. LCD brightness level queries will not work.",
> +   "label": "KlogAcpiVideoBclFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI",
>     "pattern": "Oops, 'acpi_handle' corrupt",
>     "advice": "Failed to unbind a device, the ACPI handle was corrupt.",
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Nov. 21, 2012, 2:59 a.m.
On 11/03/2012 01:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in drivers/acpi/video.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |   32 ++++++++++++++++++++++++++++++++
>   1 file changed, 32 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index bca1821..f211cb6 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -79,6 +79,38 @@
>     {
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_VIDEO",
> +   "pattern": "Failed to switch the brightness",
> +   "advice": "The ACPI video brightness for the LCD could not be set because _BCM failed.",
> +   "label": "KlogAcpiVideoBcmFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_VIDEO",
> +   "pattern": "Invalid _DOD data in element",
> +   "advice": "The ACPI _DOD control returned an element that was not an ACPI integer as expected. This element will be ignored, which could lead to reduced functionality.",
> +   "label": "KlogAcpiVideoDodFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_VIDEO",
> +   "pattern": "Invalid _DDC data",
> +   "advice": "The ACPI _DDC control is returning either a NULL buffer pointer or data that is not an ACPI buffer. The Extended Display Identification Data (EDID) structure that represents the display output device could not be fetched. This may affect video output.",
> +   "label": "KlogAcpiVideoDdcFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_VIDEO",
> +   "pattern": "Invalid _BCL data",
> +   "advice": "The ACPI _BCL control is returning either a NULL buffer pointer or data that is not an ACPI package. LCD brightness level queries will not work.",
> +   "label": "KlogAcpiVideoBclFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI",
>      "pattern": "Oops, 'acpi_handle' corrupt",
>      "advice": "Failed to unbind a device, the ACPI handle was corrupt.",
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index bca1821..f211cb6 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -79,6 +79,38 @@ 
   {
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI_VIDEO",
+   "pattern": "Failed to switch the brightness",
+   "advice": "The ACPI video brightness for the LCD could not be set because _BCM failed.",
+   "label": "KlogAcpiVideoBcmFailed"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI_VIDEO",
+   "pattern": "Invalid _DOD data in element",
+   "advice": "The ACPI _DOD control returned an element that was not an ACPI integer as expected. This element will be ignored, which could lead to reduced functionality.",
+   "label": "KlogAcpiVideoDodFailed"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI_VIDEO",
+   "pattern": "Invalid _DDC data",
+   "advice": "The ACPI _DDC control is returning either a NULL buffer pointer or data that is not an ACPI buffer. The Extended Display Identification Data (EDID) structure that represents the display output device could not be fetched. This may affect video output.",
+   "label": "KlogAcpiVideoDdcFailed"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI_VIDEO",
+   "pattern": "Invalid _BCL data",
+   "advice": "The ACPI _BCL control is returning either a NULL buffer pointer or data that is not an ACPI package. LCD brightness level queries will not work.",
+   "label": "KlogAcpiVideoBclFailed"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI",
    "pattern": "Oops, 'acpi_handle' corrupt",
    "advice": "Failed to unbind a device, the ACPI handle was corrupt.",